The U-blox F9P driver uses the GNSS_RTK_DATA_CALLBACK_DEFINE macro to
register a callback for when RTK data is available. This is an issue when
multiple instances of the F9P are available and RTK is enabled since this
macro leads to a naming collision. The following compilation error is
reported:
error: redefinition of '_gnss_rtk_data_callback__f9p_rtk_data_cb'
This is because GNSS_RTK_DATA_CALLBACK_DEFINE only uses `_callback` to
identify the callback being registered. As a fix, use the recently
introduced GNSS_DT_RTK_DATA_CALLBACK_DEFINE instead, which takes into
account the `_node_id` while naming the callback.
Signed-off-by: Pedro André <pedro@sentrytechnologies.ai>
The current GNSS_DATA_CALLBACK_DEFINE, GNSS_SATELLITES_CALLBACK_DEFINE and
GNSS_RTK_DATA_CALLBACK_DEFINE macros only utilize `_callback` when naming
the respective callback. This means that if the same callback function is
used more than once, there will be naming conflicts.
In order to allow the same callback function to be used several times for
specific gnss devices, introduce GNSS_DT_DATA_CALLBACK_DEFINE,
GNSS_DT_SATELLITES_CALLBACK_DEFINE and GNSS_DT_RTK_DATA_CALLBACK_DEFINE
macros that take a device tree node identifier instead of a device
reference. This makes it possible to name the callback using both
`_node_id` and `_callback`. Such will uniquely identify any combination of
gnss device and callback.
Signed-off-by: Pedro André <pedro@sentrytechnologies.ai>
It shouldn't be needed to execute UDP sockets tests in a fixed order
(currently enforced by embedding the test number into the test case
name). In fact, this was only needed, as two test cases worked as
prerequisites for other tests, that should've been done in the setup()
function though.
Therefore, consolidate the two test cases which pre-configured the test
interface into a proper setup() function executed before the test
suite, and get rid of the confusing test case numbering.
There also was a race in TX time test due to incorrect mutex use, so fix
that by using semaphore instead.
Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Rebinding of UDP sockets works just fine and there's really no reason to
disallow it. Keep the restriction for stream sockets only (as our TCP
implementation doesn't support rebinding).
Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
Add the node for on board EEPROM devices. Only the basic compatible
functions implemented. EUI-48 Node Address not added.
Add eeprom to the support list of the board.
Signed-off-by: Tony Han <tony.han@microchip.com>
xt-clang complains about the clock ratio difference is unsigned
when being fed to abs(), though GCC does not. So type cast that
to signed integer before feeding to abs(). Clock ratio could be
big enough to overflow signed 32-bit integer. So we first cast
it to be a signed 64-bit integer before substraction.
Signed-off-by: Daniel Leung <daniel.leung@intel.com>
The eSCO S4 settings feature should be enabled for CVSD Coding. It is
suggested by the HFP specification.
Set the eSCO S4 Settings Supported bit if the Secure connection is
supported by controller.
Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
In current implementation, the return value of `BT_FEAT_TEST()` is not
a boolean type. However, the macro `BT_FEAT_TEST()` is used as a type
with a return type value of boolean.
Change the return type of `BT_FEAT_TEST()` to boolean type to make it
easy to use.
Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
Replace direct conn->type comparisons with connection type helper
functions in SMP module. This includes:
- Update copyright headers to include Xiaomi Corporation
- Replace conn->type == BT_CONN_TYPE_LE with bt_conn_is_le(conn)
- Replace conn->type == BT_CONN_TYPE_BR with bt_conn_is_br(conn)
- Replace bt_conn_is_type(conn, BT_CONN_TYPE_LE | BT_CONN_TYPE_BR)
with !bt_conn_is_br(conn) && !bt_conn_is_le(conn) for clearer logic
- Replace IS_ENABLED(CONFIG_BT_CLASSIC) && (conn->type == BT_CONN_TYPE_BR)
with bt_conn_is_br(conn) for simplified condition
This change completes the connection type helper refactoring across
the Bluetooth host stack, improving code consistency and readability.
Signed-off-by: Kai Cheng <chengkai@xiaomi.com>
Replace direct conn->type comparisons with connection type helper
functions in L2CAP module. This includes:
- Update copyright headers to include Xiaomi Corporation
- Replace IS_ENABLED(CONFIG_BT_CLASSIC) && conn->type == BT_CONN_TYPE_BR
with bt_conn_is_br(conn) for cleaner code
- Replace conn->type != BT_CONN_TYPE_LE with !bt_conn_is_le(conn)
- Replace chan->conn->type == BT_CONN_TYPE_BR with
bt_conn_is_br(chan->conn)
This change improves code readability and maintains consistency
with the connection type helper refactoring across the Bluetooth
host stack.
Signed-off-by: Kai Cheng <chengkai@xiaomi.com>
Replace direct conn->type comparisons with connection type helper
functions in HCI core module. This includes:
- Update copyright headers to include Xiaomi Corporation
- Replace conn->type != BT_CONN_TYPE_LE with !bt_conn_is_le(conn)
- Replace conn->type == BT_CONN_TYPE_SCO with bt_conn_is_sco(conn)
- Replace conn->type == BT_CONN_TYPE_BR with bt_conn_is_br(conn)
- Replace conn->type == BT_CONN_TYPE_LE with bt_conn_is_le(conn)
This change improves code consistency and maintains the same
refactoring pattern applied across the Bluetooth host stack.
Signed-off-by: Kai Cheng <chengkai@xiaomi.com>
Check if the received AT command `ATD` is valid. When the semicolon is
missing, return the error.
Remove the semicolon from the received valid data and notify received
number or memory location value.
Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
Only voice calls are supported by HFP specification. And the
semicolon character shall be added when the voice call is originated.
Add the semicolon character to force the ATD command to end with
semicolon character.
Signed-off-by: Lyle Zhu <lyle.zhu@nxp.com>
This driver was renamed in
ab7a6de5bb
while the old kconfig options and dts binding were deprecated for 4.2
Let's remove them now.
Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
In order to avoid duplication of logic in runners, allow subclasses
of ZephyrBinaryRunner to set self.dry_run so that they can then reuse
the logic in core.py to log instead of execute.
Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Move the argparse.add_argument() call to the abstract base class and
augment the RunnerCaps class with a dry_run parameter.
Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
Add a helper function to query how old the data in a channel is. Output
is converted to milliseconds as `k_ticks` objects cannot be compared
directly.
Signed-off-by: Jordan Yates <jordan@embeint.com>
Add scmi_cpu_info_get API to query CPU information via
NXP SCMI CPU domain protocol.
Retrieves run mode, sleep mode, and reset vector addresses
for the specified CPU ID using CPU_INFO_GET command.
Signed-off-by: Yongxu Wang <yongxu.wang@nxp.com>
Add scmi_cpu_reset_vector API for NXP SCMI CPU domain protocol.
This API allows setting CPU reset vector addresses using the
CPU_RESET_VECTOR_SET command. The vector address must point to
the initial address of the vector table
Supports 64-bit addresses and boot/start/resume vector flags.
Signed-off-by: Yongxu Wang <yongxu.wang@nxp.com>
actual_length needs to be set also for the OUT transfers. Assume that
requested length was transferred when there are no errors.
Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
Clean indentation in I2S_DMA_CHANNEL_INIT(), I2S_STM32_INIT() macros
of STM32 I2S driver, and SAI_DMA_CHANNEL_INIT() and I2S_STM32_SAI_INIT()
macros of STM32 I2S/SAI driver.
No functional change.
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Replace uses of UTIL_AND() with IF_ENABLED() that is far more
readable when initializing or not a structure instance.
No functional change.
Signed-off-by: Etienne Carriere <etienne.carriere@st.com>
Having variable declarations after labels causes build failures with
Clang/LLVM:
subsys/bluetooth/host/classic/avrcp.c:1269:2: error: label followed by a
declaration is a C23 extension [-Werror,-Wc23-extensions]
1269 | uint8_t failed_evt = 0;
| ^
/subsys/bluetooth/host/classic/avrcp.c:3809:3: error: label followed by a
declaration is a C23 extension [-Werror,-Wc23-extensions]
3809 | uint64_t identifier = sys_get_be64(data->identifier);
| ^
Fix these by moving the declarations to the top of the function in the
first case and add braces for the second.
Signed-off-by: Johan Hedberg <johan.hedberg@silabs.com>
currently h_bridge_stepper driver is directly placed in drivers/stepper
and step_dir folder contains only gpio specific functionalities. This
commit reorganizes the h_bridge_stepper in gpio_stepper folder to organize
drivers and libs based on functionality.
Signed-off-by: Jilay Pandya <jilay.pandya@outlook.com>
tmc51xx has already been placed in its dedicated folder, however,
tmc50xx is not. use absolute path for including tmc_rampgem_template
Kconfig.
Signed-off-by: Jilay Pandya <jilay.pandya@outlook.com>
Adds function for app to obtain page table usage statistics,
allowing fine tuning of numbers of L1 and L2 page table
array.
Signed-off-by: Daniel Leung <daniel.leung@intel.com>
When adding new memory domains, we need to start from kernel
page tables by duplicating them. However, there is no need to
duplicate all in-use page tables as some memory regions remain
unchanged. Fror example, hardware register region where only
kernel has access does not need to be duplicated across all
memory domains. The same L2 table can be used among them.
This changes the L2 page table allocation to be copy-on-write
where we only need to duplicate a L2 table if changes need to
be made on it.
Signed-off-by: Daniel Leung <daniel.leung@intel.com>
If the page tables are not cached, there is no need to do any
cache ops to flush or invalidate the data in cache. So skip them
if the page tables are not cached. Saves a few CPU cycles.
Signed-off-by: Daniel Leung <daniel.leung@intel.com>
In l2_page_table_unmap(), invalidating TLBs should be limited to
the address and not the whole auto-refill TLBs. Also fix a bug
where the EXEC bit should be determined from the L2 PTE and not
the L1 PTE.
Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Some macros for the page tables array are local to the file so
there is no need to prefix them with XTENSA_. Simplify by
removing the XTENSA_ prefix, and clairfy if needed.
Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Almost all page table entry (PTE) related macros are only used
in one source file. These macros are considered the internal
working of MMU. There is no need to expose them in header file
for other to reference. So move them into the source file where
it is only place they are used. Bonus is that we can shorten
the macro names as they are now local to the file. Makes it
easier to read, and few keystrokes to input.
Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This skips the redirection of backup attributes and ring via
some SW field macros, and use the PTE bits directly. Should
make it easier to decode what's going on.
Signed-off-by: Daniel Leung <daniel.leung@intel.com>
The fields in macro should be done with both shift and mask
values to make it clear. So amend some macros so that
the presentation are unified for them.
Signed-off-by: Daniel Leung <daniel.leung@intel.com>
Adds snippets-text-sections.ld to linker scripts. So that
the mem_map test can run on qemu_xtensa/dc233c/mmu.
Signed-off-by: Daniel Leung <daniel.leung@intel.com>
