zephyr/subsys
Ulf Magnusson eddd98f811 kconfig: Replace some single-symbol 'if's with 'depends on'
I think people might be reading differences into 'if' and 'depends on'
that aren't there, like maybe 'if' being needed to "hide" a symbol,
while 'depends on' just adds a dependency.

There are no differences between 'if' and 'depends on'. 'if' is just a
shorthand for 'depends on'. They work the same when it comes to creating
implicit menus too.

The way symbols get "hidden" is through their dependencies not being
satisfied ('if'/'depends on' get copied up as a dependency on the
prompt).

Since 'if' and 'depends on' are the same, an 'if' with just a single
symbol in it can be replaced with a 'depends on'. IMO, it's best to
avoid 'if' there as a style choice too, because it confuses people into
thinking there's deep Kconfig magic going on that requires 'if'.

Going for 'depends on' can also remove some nested 'if's, which
generates nicer symbol information and docs, because nested 'if's really
are so simple/dumb that they just add the dependencies from both 'if's
to all symbols within.

Replace a bunch of single-symbol 'if's with 'depends on' to despam the
Kconfig files a bit and make it clearer how things work. Also do some
other minor related dependency refactoring.

The replacement isn't complete. Will fix up the rest later. Splitting it
a bit to make it more manageable.

(Everything above is true for choices, menus, and comments as well.)

Detected by tweaking the Kconfiglib parsing code. It's impossible to
detect after parsing, because 'if' turns into 'depends on'.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
2020-02-08 08:32:42 -05:00
..
bluetooth kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
canbus kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
console console: Have CONSOLE_GET{CHAR,LINE} dep. on SERIAL_SUPPORT_INTERRUPT 2020-01-28 12:56:50 -06:00
cpp kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
debug kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
dfu kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
disk gpio: rename typedef for devicetree flags 2020-02-05 12:00:36 +01:00
fb kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
fs treewide: use full path to flash.h header 2020-01-26 17:52:12 +01:00
jwt kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
logging kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
mgmt kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
net kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
power power: device: deduplicate suspending code 2020-02-02 09:05:15 -05:00
random random: rand32_ctr_drbg: Handle error in initialize function 2020-01-28 13:31:52 -08:00
settings settings: settings_register static table does not need mutex 2020-02-08 10:07:38 +02:00
shell kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
stats cleanup: include/: move stats.h to stats/stats.h 2019-06-27 22:55:49 -04:00
storage kconfig: Clean up header comments and make them consistent 2019-11-04 17:31:27 -05:00
testsuite kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
tracing tracing: usb: Fix build issues. 2020-02-07 20:06:17 -05:00
usb kconfig: Replace some single-symbol 'if's with 'depends on' 2020-02-08 08:32:42 -05:00
CMakeLists.txt tracing: move tracing under subsys/ 2020-02-07 15:58:05 -05:00
Kconfig tracing: move tracing under subsys/ 2020-02-07 15:58:05 -05:00