michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests: spi_loopback: Fix high RAM usage

Browse source 
Display diff of contents for large buffers is not quite helpful and
takes up huge RAM, and if a board has less RAM then this causes the test
module build failures.

So, disable display of diff and just log a failure, small buffer tests
can be used to debug such basic issues and large buffer tests can act as
a smoke test for debugging other issues. This saves about 80K of RAM.

Fixes #72792.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
This commit is contained in:
Chaitanya Tata 2024-05-16 21:47:35 +05:30 • committed by Henrik Brix Andersen
commit ef533e2144
1 changed files with 0 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/drivers/spi/spi_loopback/src/spi.c
View file

@ -88,9 +88,6 @@ static uint8_t buffer_print_rx[BUF_SIZE * 5 + 1];
static uint8_t buffer_print_tx2[BUF2_SIZE * 5 + 1];
static uint8_t buffer_print_rx2[BUF2_SIZE * 5 + 1];
static uint8_t large_buffer_print_tx[BUF3_SIZE * 5 + 1];
static uint8_t large_buffer_print_rx[BUF3_SIZE * 5 + 1];
static void to_display_format(const uint8_t *src, size_t size, char *dst)
{
size_t i;
@ -558,10 +555,6 @@ static int spi_complete_large_transfers(struct spi_dt_spec *spec)
}
if (memcmp(large_buffer_tx, large_buffer_rx, BUF3_SIZE)) {
to_display_format(large_buffer_tx, BUF3_SIZE, large_buffer_print_tx);
to_display_format(large_buffer_rx, BUF3_SIZE, large_buffer_print_rx);
LOG_ERR("Large Buffer contents are different: %s", large_buffer_print_tx);
LOG_ERR(" vs: %s", large_buffer_print_rx);
zassert_false(1, "Large Buffer contents are different");
return -1;
}
@ -691,10 +684,6 @@ static int spi_async_call(struct spi_dt_spec *spec)
}
if (memcmp(large_buffer_tx, large_buffer_rx, BUF3_SIZE)) {
to_display_format(large_buffer_tx, BUF3_SIZE, large_buffer_print_tx);
to_display_format(large_buffer_rx, BUF3_SIZE, large_buffer_print_rx);
LOG_ERR("Buffer 3 contents are different: %s", large_buffer_print_tx);
LOG_ERR(" vs: %s", large_buffer_print_rx);
zassert_false(1, "Buffer 3 contents are different");
return -1;
}