From ef533e2144629f9d6e19a49216aa1d3f7ec928aa Mon Sep 17 00:00:00 2001 From: Chaitanya Tata Date: Thu, 16 May 2024 21:47:35 +0530 Subject: [PATCH] tests: spi_loopback: Fix high RAM usage Display diff of contents for large buffers is not quite helpful and takes up huge RAM, and if a board has less RAM then this causes the test module build failures. So, disable display of diff and just log a failure, small buffer tests can be used to debug such basic issues and large buffer tests can act as a smoke test for debugging other issues. This saves about 80K of RAM. Fixes #72792. Signed-off-by: Chaitanya Tata --- tests/drivers/spi/spi_loopback/src/spi.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/tests/drivers/spi/spi_loopback/src/spi.c b/tests/drivers/spi/spi_loopback/src/spi.c index ea76f8e4f7b..f091f436396 100644 --- a/tests/drivers/spi/spi_loopback/src/spi.c +++ b/tests/drivers/spi/spi_loopback/src/spi.c @@ -88,9 +88,6 @@ static uint8_t buffer_print_rx[BUF_SIZE * 5 + 1]; static uint8_t buffer_print_tx2[BUF2_SIZE * 5 + 1]; static uint8_t buffer_print_rx2[BUF2_SIZE * 5 + 1]; -static uint8_t large_buffer_print_tx[BUF3_SIZE * 5 + 1]; -static uint8_t large_buffer_print_rx[BUF3_SIZE * 5 + 1]; - static void to_display_format(const uint8_t *src, size_t size, char *dst) { size_t i; @@ -558,10 +555,6 @@ static int spi_complete_large_transfers(struct spi_dt_spec *spec) } if (memcmp(large_buffer_tx, large_buffer_rx, BUF3_SIZE)) { - to_display_format(large_buffer_tx, BUF3_SIZE, large_buffer_print_tx); - to_display_format(large_buffer_rx, BUF3_SIZE, large_buffer_print_rx); - LOG_ERR("Large Buffer contents are different: %s", large_buffer_print_tx); - LOG_ERR(" vs: %s", large_buffer_print_rx); zassert_false(1, "Large Buffer contents are different"); return -1; } @@ -691,10 +684,6 @@ static int spi_async_call(struct spi_dt_spec *spec) } if (memcmp(large_buffer_tx, large_buffer_rx, BUF3_SIZE)) { - to_display_format(large_buffer_tx, BUF3_SIZE, large_buffer_print_tx); - to_display_format(large_buffer_rx, BUF3_SIZE, large_buffer_print_rx); - LOG_ERR("Buffer 3 contents are different: %s", large_buffer_print_tx); - LOG_ERR(" vs: %s", large_buffer_print_rx); zassert_false(1, "Buffer 3 contents are different"); return -1; }