michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: modem: gsm: Do not reference possible null pointer

Browse source 
The ppp_dev was used even if its value could be NULL.

Fixes #25781
Coverity-CID: 210031

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2020-06-02 16:57:10 +03:00
commit d81be8fd9c
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/modem/gsm_ppp.c
View file

@ -244,14 +244,14 @@ static int gsm_setup_mccmno(struct gsm_modem *gsm)
static void set_ppp_carrier_on(struct gsm_modem *gsm) static void set_ppp_carrier_on(struct gsm_modem *gsm)
{ {
struct device *ppp_dev = device_get_binding(CONFIG_NET_PPP_DRV_NAME); struct device *ppp_dev = device_get_binding(CONFIG_NET_PPP_DRV_NAME);
const struct ppp_api *api = const struct ppp_api *api;
(const struct ppp_api *)ppp_dev->driver_api;
if (!ppp_dev) { if (!ppp_dev) {
LOG_ERR("Cannot find PPP %s!", "device"); LOG_ERR("Cannot find PPP %s!", "device");
return; return;
} }
api = (const struct ppp_api *)ppp_dev->driver_api;
api->start(ppp_dev); api->start(ppp_dev);
} }