From d81be8fd9c3df83e0102b208c69a544a7d36a200 Mon Sep 17 00:00:00 2001 From: Jukka Rissanen Date: Tue, 2 Jun 2020 16:57:10 +0300 Subject: [PATCH] drivers: modem: gsm: Do not reference possible null pointer The ppp_dev was used even if its value could be NULL. Fixes #25781 Coverity-CID: 210031 Signed-off-by: Jukka Rissanen --- drivers/modem/gsm_ppp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/modem/gsm_ppp.c b/drivers/modem/gsm_ppp.c index 922d44e5d36..152f833d169 100644 --- a/drivers/modem/gsm_ppp.c +++ b/drivers/modem/gsm_ppp.c @@ -244,14 +244,14 @@ static int gsm_setup_mccmno(struct gsm_modem *gsm) static void set_ppp_carrier_on(struct gsm_modem *gsm) { struct device *ppp_dev = device_get_binding(CONFIG_NET_PPP_DRV_NAME); - const struct ppp_api *api = - (const struct ppp_api *)ppp_dev->driver_api; + const struct ppp_api *api; if (!ppp_dev) { LOG_ERR("Cannot find PPP %s!", "device"); return; } + api = (const struct ppp_api *)ppp_dev->driver_api; api->start(ppp_dev); }