michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: sensor: bmi270: don't force val2 > 0

Browse source 
The struct sensor_value type does NOT require val2 to be positive. The
removed code is in fact a rather serious bug, probably put in place
because it makes printing sensor_values easier.

Signed-off-by: Benjamin Lindqvist <benjamin@eub.se>
This commit is contained in:
Benjamin Lindqvist 2023-01-04 15:53:38 +01:00 • committed by Lauren Murphy
commit 7ffc200820
1 changed files with 0 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

12
drivers/sensor/bmi270/bmi270.c
View file

@ -82,12 +82,6 @@ static void channel_accel_convert(struct sensor_value *val, int64_t raw_val,
val->val1 = raw_val / 1000000LL;
val->val2 = raw_val % 1000000LL;
/* Normalize val to make sure val->val2 is positive */
if (val->val2 < 0) {
val->val1 -= 1LL;
val->val2 += 1000000LL;
}
}
static void channel_gyro_convert(struct sensor_value *val, int64_t raw_val,
@ -100,12 +94,6 @@ static void channel_gyro_convert(struct sensor_value *val, int64_t raw_val,
/ (180LL * INT16_MAX)) / 1000000LL;
val->val2 = ((raw_val * (int64_t) range * SENSOR_PI)
/ (180LL * INT16_MAX)) % 1000000LL;
/* Normalize val to make sure val->val2 is positive */
if (val->val2 < 0) {
val->val1 -= 1LL;
val->val2 += 1000000LL;
}
}
static uint8_t acc_odr_to_reg(const struct sensor_value *val)