From 7ffc20082023e88d96e3dee887e08c3512e4b263 Mon Sep 17 00:00:00 2001 From: Benjamin Lindqvist Date: Wed, 4 Jan 2023 15:53:38 +0100 Subject: [PATCH] drivers: sensor: bmi270: don't force val2 > 0 The struct sensor_value type does NOT require val2 to be positive. The removed code is in fact a rather serious bug, probably put in place because it makes printing sensor_values easier. Signed-off-by: Benjamin Lindqvist --- drivers/sensor/bmi270/bmi270.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/sensor/bmi270/bmi270.c b/drivers/sensor/bmi270/bmi270.c index 1e865e0ce4f..be65e705596 100644 --- a/drivers/sensor/bmi270/bmi270.c +++ b/drivers/sensor/bmi270/bmi270.c @@ -82,12 +82,6 @@ static void channel_accel_convert(struct sensor_value *val, int64_t raw_val, val->val1 = raw_val / 1000000LL; val->val2 = raw_val % 1000000LL; - - /* Normalize val to make sure val->val2 is positive */ - if (val->val2 < 0) { - val->val1 -= 1LL; - val->val2 += 1000000LL; - } } static void channel_gyro_convert(struct sensor_value *val, int64_t raw_val, @@ -100,12 +94,6 @@ static void channel_gyro_convert(struct sensor_value *val, int64_t raw_val, / (180LL * INT16_MAX)) / 1000000LL; val->val2 = ((raw_val * (int64_t) range * SENSOR_PI) / (180LL * INT16_MAX)) % 1000000LL; - - /* Normalize val to make sure val->val2 is positive */ - if (val->val2 < 0) { - val->val1 -= 1LL; - val->val2 += 1000000LL; - } } static uint8_t acc_odr_to_reg(const struct sensor_value *val)