michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: if: Delay IPv6 DAD if network interface is down

Browse source 
If the network interface is down, then IPv6 DAD (Duplicate
Address Detection) cannot be done if new IPv6 address is added
to the network interface. This can happen in Bluetooth, where
network interface is taken up only after there is a BT connection.
The DAD is delayed and done later after the network interface is up.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2017-07-27 15:20:35 +03:00
commit 77eddf68c4
1 changed files with 29 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

36
subsys/net/ip/net_if.c
View file

@ -433,15 +433,23 @@ static void net_if_ipv6_start_dad(struct net_if *iface,
struct net_if_addr *ifaddr)
{
ifaddr->addr_state = NET_ADDR_TENTATIVE;
ifaddr->dad_count = 1;
NET_DBG("Interface %p ll addr %s tentative IPv6 addr %s", iface,
net_sprint_ll_addr(iface->link_addr.addr,
iface->link_addr.len),
net_sprint_ipv6_addr(&ifaddr->address.in6_addr));
if (net_if_is_up(iface)) {
NET_DBG("Interface %p ll addr %s tentative IPv6 addr %s",
iface,
net_sprint_ll_addr(iface->link_addr.addr,
iface->link_addr.len),
net_sprint_ipv6_addr(&ifaddr->address.in6_addr));
if (!net_ipv6_start_dad(iface, ifaddr)) {
k_delayed_work_submit(&ifaddr->dad_timer, DAD_TIMEOUT);
ifaddr->dad_count = 1;
if (!net_ipv6_start_dad(iface, ifaddr)) {
k_delayed_work_submit(&ifaddr->dad_timer, DAD_TIMEOUT);
}
} else {
NET_DBG("Interface %p is down, starting DAD for %s later.",
iface,
net_sprint_ipv6_addr(&ifaddr->address.in6_addr));
}
}
@ -449,6 +457,7 @@ void net_if_start_dad(struct net_if *iface)
{
struct net_if_addr *ifaddr;
struct in6_addr addr = { };
int i;
net_ipv6_addr_create_iid(&addr, &iface->link_addr);
@ -457,6 +466,19 @@ void net_if_start_dad(struct net_if *iface)
NET_ERR("Cannot add %s address to interface %p, DAD fails",
net_sprint_ipv6_addr(&addr), iface);
}
/* Start DAD for all the addresses that were added earlier when
* the interface was down.
*/
for (i = 0; i < NET_IF_MAX_IPV6_ADDR; i++) {
if (!iface->ipv6.unicast[i].is_used ||
iface->ipv6.unicast[i].address.family != AF_INET6 ||
&iface->ipv6.unicast[i] == ifaddr) {
continue;
}
net_if_ipv6_start_dad(iface, &iface->ipv6.unicast[i]);
}
}
void net_if_ipv6_dad_failed(struct net_if *iface, const struct in6_addr *addr)