michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: shell: Do not access NULL pointer if interface is down

Browse source 
Normally network interface is always UP, but Bluetooth
interfaces are down until connected. So if this is the case,
then check the interface status before trying to access variables
that are NULL. This was seen with "net iface" shell command when
BT was enabled.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
This commit is contained in:
Jukka Rissanen 2017-07-27 14:35:17 +03:00
commit f8c5f69780
2 changed files with 19 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

14
include/net/net_if.h
View file

@ -1183,6 +1183,20 @@ void net_if_foreach(net_if_cb_t cb, void *user_data);
*/
int net_if_up(struct net_if *iface);
/**
* @brief Check if interface is up.
*
* @param iface Pointer to network interface
*
* @return True if interface is up, False if it is down.
*/
static inline bool net_if_is_up(struct net_if *iface)
{
NET_ASSERT(iface);
return atomic_test_bit(iface->flags, NET_IF_UP);
}
/**
* @brief Bring interface down
*

5
subsys/net/ip/net_shell.c
View file

@ -98,6 +98,11 @@ static void iface_cb(struct net_if *iface, void *user_data)
printk("Interface %p\n", iface);
printk("====================\n");
if (!net_if_is_up(iface)) {
printk("Interface is down.\n");
return;
}
printk("Link addr : %s\n", net_sprint_ll_addr(iface->link_addr.addr,
iface->link_addr.len));
printk("MTU : %d\n", iface->mtu);