michaelh/zephyr
1
0
Fork 0
Code Releases Activity

spi: nrfx_spim: fix incorrect clock control logic

Browse source 
To determine whether device runtime PM is enabled on a device, use
`pm_device_runtime_is_enabled`. This results in the same behaviour when
`CONFIG_PM_DEVICE_RUNTIME=n`, but properly controls the clocks on a
per-instance basis when `CONFIG_PM_DEVICE_RUNTIME=y`.

Signed-off-by: Jordan Yates <jordan@embeint.com>
This commit is contained in:
Jordan Yates 2025-05-02 16:30:42 +10:00 • committed by Anas Nashif
commit 6e0d0f5879
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
drivers/spi/spi_nrfx_spim.c
View file

@ -161,7 +161,7 @@ static inline void finalize_spi_transaction(const struct device *dev, bool deact
nrfy_spim_disable(reg);
}
if (!IS_ENABLED(CONFIG_PM_DEVICE_RUNTIME)) {
if (!pm_device_runtime_is_enabled(dev)) {
release_clock(dev);
}
@ -550,7 +550,7 @@ static int transceive(const struct device *dev,
error = configure(dev, spi_cfg);
if (error == 0 && !IS_ENABLED(CONFIG_PM_DEVICE_RUNTIME)) {
if (error == 0 && !pm_device_runtime_is_enabled(dev)) {
error = request_clock(dev);
}
@ -686,7 +686,7 @@ static int spim_resume(const struct device *dev)
nrf_gpd_retain_pins_set(dev_config->pcfg, false);
#endif
return IS_ENABLED(CONFIG_PM_DEVICE_RUNTIME) ? request_clock(dev) : 0;
return pm_device_runtime_is_enabled(dev) ? request_clock(dev) : 0;
}
static void spim_suspend(const struct device *dev)
@ -699,7 +699,7 @@ static void spim_suspend(const struct device *dev)
dev_data->initialized = false;
}
if (IS_ENABLED(CONFIG_PM_DEVICE_RUNTIME)) {
if (pm_device_runtime_is_enabled(dev)) {
release_clock(dev);
}