michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: pinctrl: xec: Prevent glitch for QMSPI on MAF

Browse source 
Whenever EC bootloader already configured a pin as output and
high, any further reconfiguration via pinctrl driver causes a
glitch in said pin with current sequence.

Defer pin direction configuration to be last operation over
gpio control register to avoid the glitch.

Signed-off-by: Jose Alberto Meza <jose.a.meza.arellano@intel.com>
This commit is contained in:
Jose Alberto Meza 2022-05-02 15:52:21 -07:00 • committed by Maureen Helm
commit 3ebe2a8e80
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
drivers/pinctrl/pinctrl_mchp_xec.c
View file

@ -74,7 +74,7 @@ static int xec_config_pin(uint32_t portpin, uint32_t conf, uint32_t altf)
/* default input pad enabled, buffer type push-pull, no internal pulls */
msk |= (BIT(MCHP_GPIO_CTRL_INPAD_DIS_POS) | MCHP_GPIO_CTRL_BUFT_MASK |
MCHP_GPIO_CTRL_PUD_MASK | MCHP_GPIO_CTRL_DIR_MASK |
MCHP_GPIO_CTRL_PUD_MASK |
MCHP_GPIO_CTRL_MUX_MASK);
if (conf & BIT(MCHP_XEC_PIN_LOW_POWER_POS)) {