From 3ebe2a8e802119390379c6c977aefc200687450d Mon Sep 17 00:00:00 2001 From: Jose Alberto Meza Date: Mon, 2 May 2022 15:52:21 -0700 Subject: [PATCH] drivers: pinctrl: xec: Prevent glitch for QMSPI on MAF Whenever EC bootloader already configured a pin as output and high, any further reconfiguration via pinctrl driver causes a glitch in said pin with current sequence. Defer pin direction configuration to be last operation over gpio control register to avoid the glitch. Signed-off-by: Jose Alberto Meza --- drivers/pinctrl/pinctrl_mchp_xec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl_mchp_xec.c b/drivers/pinctrl/pinctrl_mchp_xec.c index e2ef8134ff8..4d8f390d87e 100644 --- a/drivers/pinctrl/pinctrl_mchp_xec.c +++ b/drivers/pinctrl/pinctrl_mchp_xec.c @@ -74,7 +74,7 @@ static int xec_config_pin(uint32_t portpin, uint32_t conf, uint32_t altf) /* default input pad enabled, buffer type push-pull, no internal pulls */ msk |= (BIT(MCHP_GPIO_CTRL_INPAD_DIS_POS) | MCHP_GPIO_CTRL_BUFT_MASK | - MCHP_GPIO_CTRL_PUD_MASK | MCHP_GPIO_CTRL_DIR_MASK | + MCHP_GPIO_CTRL_PUD_MASK | MCHP_GPIO_CTRL_MUX_MASK); if (conf & BIT(MCHP_XEC_PIN_LOW_POWER_POS)) {