michaelh/zephyr
1
0
Fork 0
Code Releases Activity

intel_adsp/cavs: power: Fix INTLEVEL value

Browse source 
In pm_state_set we can't just call k_cpu_idle() because
this will clear out PS.INTLEVEL. Use k_cpu_atomic_idle instead
since Zephyr's expect interruptions to be locked after pm_state_set.

Signed-off-by: Flavio Ceolin <flavio.ceolin@intel.com>
This commit is contained in:
Flavio Ceolin 2024-01-20 00:36:59 +00:00 • committed by Maureen Helm
commit 3e5a593de9
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
soc/xtensa/intel_adsp/cavs/power.c
View file

@ -163,7 +163,7 @@ void pm_state_set(enum pm_state state, uint8_t substate_id)
/* do power down - this function won't return */ /* do power down - this function won't return */
power_down_cavs(true, uncache_to_cache(&hpsram_mask[0])); power_down_cavs(true, uncache_to_cache(&hpsram_mask[0]));
} else { } else {
k_cpu_idle(); k_cpu_atomic_idle(arch_irq_lock());
} }
} else { } else {
__ASSERT(false, "invalid argument - unsupported power state"); __ASSERT(false, "invalid argument - unsupported power state");
@ -183,6 +183,12 @@ void pm_state_exit_post_ops(enum pm_state state, uint8_t substate_id)
} else { } else {
__ASSERT(false, "invalid argument - unsupported power state"); __ASSERT(false, "invalid argument - unsupported power state");
} }
/**
* We don't have the key used to lock interruptions here.
* Just set PS.INTLEVEL to 0.
*/
__asm__ volatile ("rsil a2, 0");
} }
#endif /* CONFIG_PM */ #endif /* CONFIG_PM */