michaelh/zephyr
1
0
Fork 0
Code Releases Activity

boards: intel_adsp: add comments explaining log IDs start from 1

Browse source 
The mismatch between the slot number and the sequence ("id") made me
suspect a bug for too long. Fix one related comment and add two more. No
code change.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
This commit is contained in:
Marc Herbert 2021-05-19 17:26:48 -07:00 • committed by Christopher Friedt
commit 2fac69422c
3 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
soc/xtensa/intel_adsp/common/trace_out.c
View file

@ -11,8 +11,8 @@
* for communication with the host processor as a shared memory
* region. The protocol uses an array of 64-byte "slots", each of
* which is prefixed by a 16 bit magic number followed by a sequential
* ID number. The remaining bytes are a (potentially nul-terminated)
* string containing output data.
* ID number starting from 1. The remaining bytes are a (potentially
* nul-terminated) string containing output data.
*
* IMPORTANT NOTE on cache coherence: the shared memory window is in
* HP-SRAM. Each DSP core has an L1 cache that is incoherent (!) from