michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: ieee802154_cc1200: Fix unchecked return value coverity issue

Browse source 
Verify the return value of `gpio_add_callback()` call.

CID: 240678

Fixes #39825

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
This commit is contained in:
Robert Lubos 2021-10-29 14:40:44 +02:00 • committed by Carles Cufí
commit 17856620cf
1 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

13
drivers/ieee802154/ieee802154_cc1200.c
View file

@ -199,13 +199,18 @@ static void enable_gpio0_interrupt(const struct device *dev, bool enable)
gpio_pin_interrupt_configure_dt(&cfg->interrupt, mode); gpio_pin_interrupt_configure_dt(&cfg->interrupt, mode);
} }
static void setup_gpio_callback(const struct device *dev) static int setup_gpio_callback(const struct device *dev)
{ {
const struct cc1200_config *cfg = dev->config; const struct cc1200_config *cfg = dev->config;
struct cc1200_context *cc1200 = dev->data; struct cc1200_context *cc1200 = dev->data;
gpio_init_callback(&cc1200->rx_tx_cb, gpio0_int_handler, BIT(cfg->interrupt.pin)); gpio_init_callback(&cc1200->rx_tx_cb, gpio0_int_handler, BIT(cfg->interrupt.pin));
gpio_add_callback(cfg->interrupt.port, &cc1200->rx_tx_cb);
if (gpio_add_callback(cfg->interrupt.port, &cc1200->rx_tx_cb) != 0) {
return -EIO;
}
return 0;
} }
/**************** /****************
@ -713,7 +718,9 @@ static int power_on_and_setup(const struct device *dev)
return -EIO; return -EIO;
} }
setup_gpio_callback(dev); if (setup_gpio_callback(dev) != 0) {
return -EIO;
}
return rf_calibrate(dev); return rf_calibrate(dev);
} }