michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: ieee802154_cc2520: Fix unchecked return value coverity issue

Browse source 
Verify the return value of `gpio_add_callback()` calls.

CID: 240700

Fixes #39806

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
This commit is contained in:
Robert Lubos 2021-10-29 13:45:13 +02:00 • committed by Carles Cufí
commit cf49c8676c
1 changed files with 13 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

17
drivers/ieee802154/ieee802154_cc2520.c
View file

@ -429,16 +429,23 @@ static void enable_sfd_interrupt(const struct device *dev,
gpio_pin_interrupt_configure_dt(&cfg->sfd, mode);
}
static inline void setup_gpio_callbacks(const struct device *dev)
static inline int setup_gpio_callbacks(const struct device *dev)
{
const struct cc2520_config *cfg = dev->config;
struct cc2520_context *cc2520 = dev->data;
gpio_init_callback(&cc2520->sfd_cb, sfd_int_handler, BIT(cfg->sfd.pin));
gpio_add_callback(cfg->sfd.port, &cc2520->sfd_cb);
if (gpio_add_callback(cfg->sfd.port, &cc2520->sfd_cb) != 0) {
return -EIO;
}
gpio_init_callback(&cc2520->fifop_cb, fifop_int_handler, BIT(cfg->fifop.pin));
gpio_add_callback(cfg->fifop.port, &cc2520->fifop_cb);
if (gpio_add_callback(cfg->fifop.port, &cc2520->fifop_cb) != 0) {
return -EIO;
}
return 0;
}
@ -931,7 +938,9 @@ static int power_on_and_setup(const struct device *dev)
/* Cleaning up TX fifo */
instruct_sflushtx(dev);
setup_gpio_callbacks(dev);
if (setup_gpio_callbacks(dev) != 0) {
return -EIO;
}
cc2520_print_gpio_config(dev);