Fix host RX thread being deadlocked. The deadlock occurs because the RX thread is stuck waiting in conn_tx_alloc with K_FOREVER but if the connection is disconnected only the RX thread can unblock it in the handling of the disconnect event. This commit fixes this deadlock by splitting the processing of the disconnected event into two parts. The part needed to unblock the RX is to release resources held by unack'ed TX packets and mark the connection state as not connected anymore. The RX thread waiting for free_tx fifo and the TX thread waiting for the bt_dev.le.pkts semaphore will both check the connected state after having acquired them and will abort if disconnected. The rest of the processing will be handled at normal RX thread priority like normal. Move the bt_recv_prio handling to the Bluetooth host when the host has defined its own RX thread (CONFIG_BT_RECV_IS_RX_THREAD=n). If the HCI driver has the RX thread (CONFIG_BT_RECV_IS_RX_THREAD=y), then the responsibility to call bt_recv and bt_recv_prio correctly falls to the HCI driver. The helper function bt_hci_evt_is_prio() is replaced with bt_hci_evt_get_flags() so that the HCI driver can do this correctly. This decision to replace was made so that existing HCI drivers maintained out-of-tree will fail at compile time with the new system. Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no> Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no> Bluetooth: host: Move bt_recv_prio to host when RX thread is defined Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no>
255 lines
7.5 KiB
C
255 lines
7.5 KiB
C
/** @file
|
|
* @brief Bluetooth HCI driver API.
|
|
*/
|
|
|
|
/*
|
|
* Copyright (c) 2015-2016 Intel Corporation
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
#ifndef ZEPHYR_INCLUDE_DRIVERS_BLUETOOTH_HCI_DRIVER_H_
|
|
#define ZEPHYR_INCLUDE_DRIVERS_BLUETOOTH_HCI_DRIVER_H_
|
|
|
|
/**
|
|
* @brief HCI drivers
|
|
* @defgroup bt_hci_driver HCI drivers
|
|
* @ingroup bluetooth
|
|
* @{
|
|
*/
|
|
|
|
#include <stdbool.h>
|
|
#include <net/buf.h>
|
|
#include <bluetooth/buf.h>
|
|
#include <bluetooth/hci_vs.h>
|
|
#include <device.h>
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif
|
|
|
|
enum {
|
|
/* The host should never send HCI_Reset */
|
|
BT_QUIRK_NO_RESET = BIT(0),
|
|
};
|
|
|
|
/* @brief The HCI event shall be given to bt_recv_prio */
|
|
#define BT_HCI_EVT_FLAG_RECV_PRIO BIT(0)
|
|
/* @brief The HCI event shall be given to bt_recv. */
|
|
#define BT_HCI_EVT_FLAG_RECV BIT(1)
|
|
|
|
/** @brief Get HCI event flags.
|
|
*
|
|
* Helper for the HCI driver to get HCI event flags that describes rules that.
|
|
* must be followed.
|
|
*
|
|
* When CONFIG_BT_RECV_IS_RX_THREAD is enabled the flags
|
|
* BT_HCI_EVT_FLAG_RECV and BT_HCI_EVT_FLAG_RECV_PRIO indicates if the event
|
|
* should be given to bt_recv or bt_recv_prio.
|
|
*
|
|
* @param evt HCI event code.
|
|
*
|
|
* @return HCI event flags for the specified event.
|
|
*/
|
|
static inline uint8_t bt_hci_evt_get_flags(uint8_t evt)
|
|
{
|
|
switch (evt) {
|
|
case BT_HCI_EVT_DISCONN_COMPLETE:
|
|
return BT_HCI_EVT_FLAG_RECV | BT_HCI_EVT_FLAG_RECV_PRIO;
|
|
/* fallthrough */
|
|
#if defined(CONFIG_BT_CONN)
|
|
case BT_HCI_EVT_NUM_COMPLETED_PACKETS:
|
|
case BT_HCI_EVT_DATA_BUF_OVERFLOW:
|
|
/* fallthrough */
|
|
#endif /* defined(CONFIG_BT_CONN) */
|
|
case BT_HCI_EVT_CMD_COMPLETE:
|
|
case BT_HCI_EVT_CMD_STATUS:
|
|
return BT_HCI_EVT_FLAG_RECV_PRIO;
|
|
default:
|
|
return BT_HCI_EVT_FLAG_RECV;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @brief Receive data from the controller/HCI driver.
|
|
*
|
|
* This is the main function through which the HCI driver provides the
|
|
* host with data from the controller. The buffer needs to have its type
|
|
* set with the help of bt_buf_set_type() before calling this API.
|
|
*
|
|
* When CONFIG_BT_RECV_IS_RX_THREAD is defined then this API should not be used
|
|
* for so-called high priority HCI events, which should instead be delivered to
|
|
* the host stack through bt_recv_prio().
|
|
*
|
|
* @param buf Network buffer containing data from the controller.
|
|
*
|
|
* @return 0 on success or negative error number on failure.
|
|
*/
|
|
int bt_recv(struct net_buf *buf);
|
|
|
|
/**
|
|
* @brief Receive high priority data from the controller/HCI driver.
|
|
*
|
|
* This is the same as bt_recv(), except that it should be used for
|
|
* so-called high priority HCI events. There's a separate
|
|
* bt_hci_evt_get_flags() helper that can be used to identify which events
|
|
* have the BT_HCI_EVT_FLAG_RECV_PRIO flag set.
|
|
*
|
|
* As with bt_recv(), the buffer needs to have its type set with the help of
|
|
* bt_buf_set_type() before calling this API. The only exception is so called
|
|
* high priority HCI events which should be delivered to the host stack through
|
|
* bt_recv_prio() instead.
|
|
*
|
|
* @param buf Network buffer containing data from the controller.
|
|
*
|
|
* @return 0 on success or negative error number on failure.
|
|
*/
|
|
int bt_recv_prio(struct net_buf *buf);
|
|
|
|
/** @brief Read static addresses from the controller.
|
|
*
|
|
* @param addrs Random static address and Identity Root (IR) array.
|
|
* @param size Size of array.
|
|
*
|
|
* @return Number of addresses read.
|
|
*/
|
|
uint8_t bt_read_static_addr(struct bt_hci_vs_static_addr addrs[], uint8_t size);
|
|
|
|
/** Possible values for the 'bus' member of the bt_hci_driver struct */
|
|
enum bt_hci_driver_bus {
|
|
BT_HCI_DRIVER_BUS_VIRTUAL = 0,
|
|
BT_HCI_DRIVER_BUS_USB = 1,
|
|
BT_HCI_DRIVER_BUS_PCCARD = 2,
|
|
BT_HCI_DRIVER_BUS_UART = 3,
|
|
BT_HCI_DRIVER_BUS_RS232 = 4,
|
|
BT_HCI_DRIVER_BUS_PCI = 5,
|
|
BT_HCI_DRIVER_BUS_SDIO = 6,
|
|
BT_HCI_DRIVER_BUS_SPI = 7,
|
|
BT_HCI_DRIVER_BUS_I2C = 8,
|
|
BT_HCI_DRIVER_BUS_IPM = 9,
|
|
};
|
|
|
|
/**
|
|
* @brief Abstraction which represents the HCI transport to the controller.
|
|
*
|
|
* This struct is used to represent the HCI transport to the Bluetooth
|
|
* controller.
|
|
*/
|
|
struct bt_hci_driver {
|
|
/** Name of the driver */
|
|
const char *name;
|
|
|
|
/** Bus of the transport (BT_HCI_DRIVER_BUS_*) */
|
|
enum bt_hci_driver_bus bus;
|
|
|
|
/** Specific controller quirks. These are set by the HCI driver
|
|
* and acted upon by the host. They can either be statically
|
|
* set at buildtime, or set at runtime before the HCI driver's
|
|
* open() callback returns.
|
|
*/
|
|
uint32_t quirks;
|
|
|
|
/**
|
|
* @brief Open the HCI transport.
|
|
*
|
|
* Opens the HCI transport for operation. This function must not
|
|
* return until the transport is ready for operation, meaning it
|
|
* is safe to start calling the send() handler.
|
|
*
|
|
* If the driver uses its own RX thread, i.e.
|
|
* CONFIG_BT_RECV_IS_RX_THREAD is set, then this
|
|
* function is expected to start that thread.
|
|
*
|
|
* @return 0 on success or negative error number on failure.
|
|
*/
|
|
int (*open)(void);
|
|
|
|
/**
|
|
* @brief Send HCI buffer to controller.
|
|
*
|
|
* Send an HCI command or ACL data to the controller. The exact
|
|
* type of the data can be checked with the help of bt_buf_get_type().
|
|
*
|
|
* @note This function must only be called from a cooperative thread.
|
|
*
|
|
* @param buf Buffer containing data to be sent to the controller.
|
|
*
|
|
* @return 0 on success or negative error number on failure.
|
|
*/
|
|
int (*send)(struct net_buf *buf);
|
|
};
|
|
|
|
/**
|
|
* @brief Register a new HCI driver to the Bluetooth stack.
|
|
*
|
|
* This needs to be called before any application code runs. The bt_enable()
|
|
* API will fail if there is no driver registered.
|
|
*
|
|
* @param drv A bt_hci_driver struct representing the driver.
|
|
*
|
|
* @return 0 on success or negative error number on failure.
|
|
*/
|
|
int bt_hci_driver_register(const struct bt_hci_driver *drv);
|
|
|
|
/**
|
|
* @brief Setup the HCI transport, which usually means to reset the
|
|
* Bluetooth IC.
|
|
*
|
|
* @note A weak version of this function is included in the H4 driver, so
|
|
* defining it is optional per board.
|
|
*
|
|
* @param dev The device structure for the bus connecting to the IC
|
|
*
|
|
* @return 0 on success, negative error value on failure
|
|
*/
|
|
int bt_hci_transport_setup(struct device *dev);
|
|
|
|
/** Allocate an HCI event buffer.
|
|
*
|
|
* This function allocates a new buffer for an HCI event. It is given the
|
|
* avent code and the total length of the parameters. Upon successful return
|
|
* the buffer is ready to have the parameters encoded into it.
|
|
*
|
|
* @param evt Event OpCode.
|
|
* @param len Length of event parameters.
|
|
*
|
|
* @return Newly allocated buffer.
|
|
*/
|
|
struct net_buf *bt_hci_evt_create(uint8_t evt, uint8_t len);
|
|
|
|
/** Allocate an HCI Command Complete event buffer.
|
|
*
|
|
* This function allocates a new buffer for HCI Command Complete event.
|
|
* It is given the OpCode (encoded e.g. using the BT_OP macro) and the total
|
|
* length of the parameters. Upon successful return the buffer is ready to have
|
|
* the parameters encoded into it.
|
|
*
|
|
* @param op Command OpCode.
|
|
* @param plen Length of command parameters.
|
|
*
|
|
* @return Newly allocated buffer.
|
|
*/
|
|
struct net_buf *bt_hci_cmd_complete_create(uint16_t op, uint8_t plen);
|
|
|
|
/** Allocate an HCI Command Status event buffer.
|
|
*
|
|
* This function allocates a new buffer for HCI Command Status event.
|
|
* It is given the OpCode (encoded e.g. using the BT_OP macro) and the status
|
|
* code. Upon successful return the buffer is ready to have the parameters
|
|
* encoded into it.
|
|
*
|
|
* @param op Command OpCode.
|
|
* @param status Status code.
|
|
*
|
|
* @return Newly allocated buffer.
|
|
*/
|
|
struct net_buf *bt_hci_cmd_status_create(uint16_t op, uint8_t status);
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif
|
|
|
|
/**
|
|
* @}
|
|
*/
|
|
|
|
#endif /* ZEPHYR_INCLUDE_DRIVERS_BLUETOOTH_HCI_DRIVER_H_ */
|