eddd98f811
I think people might be reading differences into 'if' and 'depends on'
that aren't there, like maybe 'if' being needed to "hide" a symbol,
while 'depends on' just adds a dependency.
There are no differences between 'if' and 'depends on'. 'if' is just a
shorthand for 'depends on'. They work the same when it comes to creating
implicit menus too.
The way symbols get "hidden" is through their dependencies not being
satisfied ('if'/'depends on' get copied up as a dependency on the
prompt).
Since 'if' and 'depends on' are the same, an 'if' with just a single
symbol in it can be replaced with a 'depends on'. IMO, it's best to
avoid 'if' there as a style choice too, because it confuses people into
thinking there's deep Kconfig magic going on that requires 'if'.
Going for 'depends on' can also remove some nested 'if's, which
generates nicer symbol information and docs, because nested 'if's really
are so simple/dumb that they just add the dependencies from both 'if's
to all symbols within.
Replace a bunch of single-symbol 'if's with 'depends on' to despam the
Kconfig files a bit and make it clearer how things work. Also do some
other minor related dependency refactoring.
The replacement isn't complete. Will fix up the rest later. Splitting it
a bit to make it more manageable.
(Everything above is true for choices, menus, and comments as well.)
Detected by tweaking the Kconfiglib parsing code. It's impossible to
detect after parsing, because 'if' turns into 'depends on'.
Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
39 lines
1.1 KiB
Plaintext
39 lines
1.1 KiB
Plaintext
# Copyright (c) 2017 Linaro Limited
|
|
# Copyright (c) 2019 Nordic Semiconductor ASA
|
|
#
|
|
# SPDX-License-Identifier: Apache-2.0
|
|
|
|
# The following blog post is an excellent resource about pulse timing:
|
|
#
|
|
# https://wp.josh.com/2014/05/13/ws2812-neopixels-are-not-so-finicky-once-you-get-to-know-them/
|
|
|
|
menuconfig WS2812_STRIP
|
|
bool "Enable WS2812 (and compatible) LED strip driver"
|
|
select LED_STRIP_RGB_SCRATCH
|
|
help
|
|
Enable LED strip driver for daisy chains of WS2812-ish
|
|
(or WS2812B, WS2813, SK6812, or compatible) devices.
|
|
|
|
choice WS2812_STRIP_DRIVER
|
|
prompt "Driver backend"
|
|
default WS2812_STRIP_SPI
|
|
depends on WS2812_STRIP
|
|
|
|
config WS2812_STRIP_SPI
|
|
bool "Enable the SPI driver"
|
|
depends on SPI
|
|
help
|
|
The SPI driver is portable, but requires significantly more
|
|
memory (1 byte of overhead per bit of pixel data).
|
|
|
|
config WS2812_STRIP_GPIO
|
|
bool "Enable the GPIO driver"
|
|
# Only an Cortex-M0 inline assembly implementation for the nRF51
|
|
# is supported currently.
|
|
depends on SOC_SERIES_NRF51X
|
|
help
|
|
The GPIO driver does bit-banging with inline assembly,
|
|
and is not available on all SoCs.
|
|
|
|
endchoice
|