ed025b2f04
An earlier pull request implementing observe support was merged too hastily. It had a few issues: 1. The predicate for whether a request should be marked not ongoing was wrong (it checked ret != 0 instead of ret < 0) 2. Without observes in mind, MID-based deduplication is not a required feature. Deduplication was handled implicitly - the exchange would get dropped after the first response anyway, so duplicate responses would not get matched to anything. But with observes, there are several responses in an exchange. This commit adds this. 3. Using coap_request_is_observe(&internal_req->request) in the response handler requires the whole request to stay in scope for the lifetime of the observation, which I observed was not always the case. Adding an is_observe bool to the internal struct improved stability significantly. With these fixes, GETs with observe option works very well. Signed-off-by: Benjamin Lindqvist <benjamin@eub.se> |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| coap.c | ||
| coap_client.c | ||
| coap_link_format.c | ||
| coap_server.c | ||
| coap_server_shell.c | ||
| Kconfig | ||