79e6b0e0f6
As of today <zephyr/zephyr.h> is 100% equivalent to <zephyr/kernel.h>. This patch proposes to then include <zephyr/kernel.h> instead of <zephyr/zephyr.h> since it is more clear that you are including the Kernel APIs and (probably) nothing else. <zephyr/zephyr.h> sounds like a catch-all header that may be confusing. Most applications need to include a bunch of other things to compile, e.g. driver headers or subsystem headers like BT, logging, etc. The idea of a catch-all header in Zephyr is probably not feasible anyway. Reason is that Zephyr is not a library, like it could be for example `libpython`. Zephyr provides many utilities nowadays: a kernel, drivers, subsystems, etc and things will likely grow. A catch-all header would be massive, difficult to keep up-to-date. It is also likely that an application will only build a small subset. Note that subsystem-level headers may use a catch-all approach to make things easier, though. NOTE: This patch is **NOT** removing the header, just removing its usage in-tree. I'd advocate for its deprecation (add a #warning on it), but I understand many people will have concerns. Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
47 lines
1 KiB
C
47 lines
1 KiB
C
/*
|
|
* Copyright (c) 2017 Linaro Limited.
|
|
*
|
|
* SPDX-License-Identifier: Apache-2.0
|
|
*/
|
|
|
|
#include <zephyr/kernel.h>
|
|
#include <zephyr/drivers/uart.h>
|
|
#include <zephyr/drivers/console/console.h>
|
|
#include <zephyr/drivers/console/uart_console.h>
|
|
|
|
/* While app processes one input line, Zephyr will have another line
|
|
* buffer to accumulate more console input.
|
|
*/
|
|
static struct console_input line_bufs[2];
|
|
|
|
static K_FIFO_DEFINE(free_queue);
|
|
static K_FIFO_DEFINE(used_queue);
|
|
|
|
char *console_getline(void)
|
|
{
|
|
static struct console_input *cmd;
|
|
|
|
/* Recycle cmd buffer returned previous time */
|
|
if (cmd != NULL) {
|
|
k_fifo_put(&free_queue, cmd);
|
|
}
|
|
|
|
cmd = k_fifo_get(&used_queue, K_FOREVER);
|
|
return cmd->line;
|
|
}
|
|
|
|
void console_getline_init(void)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(line_bufs); i++) {
|
|
k_fifo_put(&free_queue, &line_bufs[i]);
|
|
}
|
|
|
|
/* Zephyr UART handler takes an empty buffer from free_queue,
|
|
* stores UART input in it until EOL, and then puts it into
|
|
* used_queue.
|
|
*/
|
|
uart_register_input(&free_queue, &used_queue, NULL);
|
|
}
|