The local check_call_ignore_sigint() method is an exact duplicate
of the same-named method in ZephyrBinaryRunner. Remove the
local definition and rely on the base implementation.
Signed-off-by: Andres Hernandez <andres.a.h@outlook.com>
Renaming run_client() to check_call_ignore_sigint() makes its purpose
clearer and consistent with the pattern already established in the
blackmagicprobe runner.
Then, update all callers with the new name.
run_client() is kept as a deprecated function, wrapping
check_call_ignore_sigint() for backwards compatibility.
Signed-off-by: Andres Hernandez <andres.a.h@outlook.com>
Add support for providing multiple .conf and .overlay files for a given
snippet. This uses the standard syntax of a space or semi-colon
separated list in the snippets.yml file for EXTRA_CONF_FILE,
EXTRA_DTC_OVERLAY_FILE, and SB_EXTRA_CONF_FILE. In other areas of the
build system these variables already take such a list, so this provides
a more consistent syntax in the snippets case.
Signed-off-by: Graham Roff <grahamr@qti.qualcomm.com>
shutil.copy() calls copyfile() then copymode(). On Windows the UF2
bootloader resets the MCU (unmounting the drive) after receiving the
file, before copymode() runs, raising OSError: [WinError 433]. FAT
filesystems also do not support Unix permission bits. Replace copy()
with copyfile() to transfer data only and avoid the failing chmod.
Fixes zephyrproject-rtos#107165
Signed-off-by: Taha Momayiz <momayita@mail.uc.edu>
When information about the node's matching binding is available, add
it to the dashboard. Knowing which binding matched a node is a common
source of confusion, so this hopefully is helpful additional context.
Adding this information has officially made the dt-prop-info field a
bit too complex to render inline. To avoid confusing people with the
extra info, re-work the CSS to display this new information in a grid
of key/value pairs associated with each node or property.
Signed-off-by: Martí Bolívar <mbolivar@oss.qualcomm.com>
Add the ability to specify different pre init commands for flashing, in the
case flashing needs to use a different transport/target than other
operations like debug for heterogeneous targets.
Signed-off-by: Pete Johanson <pete.johanson@analog.com>
Before a capture is started "enable" is sent to the device in case
`CONFIG_TRACING_HANDLE_HOST_CMD` is enabled to start the transmission of
tracing data from the device. However it is never stopped.
Send "disable" when the capture is stopped to stop the transmission from
the device.
Also `ser.close()` was unreachable which is also fixed.
Signed-off-by: Jeppe Odgaard <jeppe.odgaard@prevas.dk>
Parametrized tests in gtest are shown as the following example in a log:
[ FAILED ] FooTest/FooTypedTest/0.TypedTestFoo, where TypeParam = <type>
current regex of the gtest harness didn't detect such test so it marks
this as pass or that the result wasn't found. This commit extends the
regex to detect such behavior and adds unit test to verify that.
Signed-off-by: Martin Moya <moyamartin1@gmail.com>
Posix is not a library per the definition of libraries in Zephyr. It
always has been a portability layer and shall reside with other
portability layers under subsys/portability.
Addresses #99250
Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Disable the DeviceMmioCheck compliance check while documentation and
community discussion are ongoing. The check code is kept in place and
can be re-enabled by removing the self.skip() call.
See https://github.com/zephyrproject-rtos/zephyr/issues/106966
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
The check was scanning the entire file content, causing CI failures
for PRs that touch any line in an existing non-compliant driver, even
if the change is completely unrelated to the violation.
Fix this by parsing git diff -U0 hunk headers to determine which
lines were actually added in the changeset, and only flag
RAW_REG_ADDR_RE matches on those lines. The MMIO_API_RE suppression
still scans the whole file so that files already using the MMIO API
are correctly excluded.
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
The RAW_REG_ADDR_RE pattern used \w+ for the cast type, which only
matches single-word types like (uint32_t *). This misses the most
common pattern in Zephyr drivers:
.base = (struct foo_regs *)DT_INST_REG_ADDR(n),
Replace \w+ with [^)]* to match any cast expression including struct,
volatile, and multi-word types.
Also extend the pattern to catch DT_[INST_]REG_ADDR_BY_NAME() casts,
which are equally broken on MMU platforms, and scan .h files in
addition to .c files since some drivers define their config structs
in companion headers.
Before: 554 flagged lines across drivers/
After: 694 flagged lines across drivers/ (+140 newly caught)
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
Append the documentation link to Github annotation. This make it easier for
users to go directly to the relevant page from a pull request.
Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
do_create() is a classmethod and cannot access self.logger.
Use a module-level _logger instead, consistent with core.py
and __init__.py in the runners package.
Signed-off-by: Sylvio Alves <sylvio.alves@espressif.com>
Besides a custom range to run the compliance checks, allow to run on all
commits to HEAD.
This is useful when testing locally, to verify existing files in tree.
Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Add a DeviceMmioCheck to check_compliance.py that flags driver files
casting DT_REG_ADDR() or DT_INST_REG_ADDR() to a pointer without
using the device MMIO API.
.base = (SomeType *)DT_INST_REG_ADDR(n),
This stores the raw physical address and dereferences it directly. On
systems with an MMU, the physical address has no page table entry and
the access will fault unless someone else has created an identity
mapping (typically via mmu_regions.c).
Signed-off-by: Carlo Caione <ccaione@baylibre.com>
that can never succeed because it is not in the com port filter list.
This would trigger every time that a combination of --flash-before and
--serial-pty is used.
The list of monitored serial ports - at least on linux - does not contain
/dev/pts but that list is constantly checked if the /dev/pts/X device might
magically appear some day.
This is the proper fix instead of adding /dev/pts/* to the monitor list
because the reason why we need to wait is because in the codepath without
serial_pty, we might be resetting the target device, causing the dev node
to disappear/reappear. This is not the case for the virtual ports created
for serial_pty.
Signed-off-by: Lucas Romero <lucas.romero@a-labs.io>
The result property getter rebuilds the list from XML children every
access, and the setter removes all existing results then re-appends them
all. So self.case.result += [res] is O(n²) over time.
self.case.append(res) directly appends to the underlying XML element in
O(1), bypassing the expensive property entirely.
Assisted-by: Claude:claude-opus-4.6
Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Moved all `sys.path.insert` from twister's modules
to `twisterlib.__init__.py` to have only one place where all paths
are added.
Signed-off-by: Łukasz Fundakowski <lukasz.fundakowski@nordicsemi.no>
Add a compliance test for device driver APIs to make sure API
<class>_driver_api struct variables are put in the corresponding linker
section using the DEVICE_API macro.
Assisted-by: Claude:claude-opus-4.6
Signed-off-by: Pieter De Gendt <pieter.degendt@basalte.be>
Make sure that we don't allow bindings which manually
specify any defaults for the status
properties. See DTSpec 2.3.4.
Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
The status property indicates the operational status of a device.
The lack of a status property should be treated as
if the property existed with the value of "okay".
We are currently allowing defaults.
This is a continuation of
https://github.com/zephyrproject-rtos/zephyr/pull/104931
Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
Added unit tests for `twister_main.py` module to increase code coverage.
Did minor refactoring in `twister_main.py`.
Fixed type hints and added type ignores.
Removed unused variables.
Signed-off-by: Łukasz Fundakowski <lukasz.fundakowski@nordicsemi.no>
Signed-off-by: Lukasz Fundakowski <lukasz.fundakowski@nordicsemi.no>
Run the uv command to update the pinned version in
scripts/requirements-actions.txt and doc/requirements.txt.
This picks up requests>=2.33.0, mitigating CVE-2026-25645.
Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
'west sdk install' assumes the host-specific minimal SDK archive
always has a matching entry in sha256.sum and aborts with a Python
KeyError when it does not.
Detect the missing checksum entry and report a normal
west fatal error instead.
Without this patch:
west sdk install --install-base ../
KeyError: 'zephyr-sdk-1.0.0_macos-x86_64_minimal.tar.xz'
With this patch:
west sdk install --install-base ../
FATAL ERROR: No Zephyr SDK 1.0.0 bundle found for host
macos-x86_64.
Signed-off-by: Mirai SHINJO <oss@mshinjo.com>
Add quotes around binding file paths in error messages for better
readability and consistency. Also normalize paths using os.path.normpath
to ensure consistent path separators across platforms.
Signed-off-by: Yves Wang <zhengjia.wang@nxp.com>
When TOOLCHAIN_VARIANT_COMPILER is empty, we should not append
a trailing slash (/) to ZEPHYR_TOOLCHAIN_VARIANT. Or else any
matching of ZEPHYR_TOOLCHAIN_VARIANT would be incorrect.
For example, ZEPHYR_TOOLCHAIN_VARIANT == 'xt-clang' and west
build would have it correct, while twister would have it as
'xt-clang/'. This prevents kconfig from matching correctly
(possibly among other things).
Signed-off-by: Daniel Leung <daniel.leung@intel.com>
This change adds a script to generate an HTML dashboard, invoked via
west, providing a consolidated and user-friendly view of various build
artifacts and metrics. This includes footprint information (as both
tables and plots), configuration tracing, sys init levels, an interactive
devicetree browser, and more.
Signed-off-by: Graham Roff <grahamr@qti.qualcomm.com>
Signed-off-by: Martí Bolívar <mbolivar@oss.qualcomm.com>
To allow other scripts to use the initlevel information determined
by the Validator class, expose an API to get them.
Signed-off-by: Graham Roff <grahamr@qti.qualcomm.com>
In order to allow the plot.py functionality to be used by other
scripts, move the code into a separate function that can be
imported.
Signed-off-by: Graham Roff <grahamr@qti.qualcomm.com>
Introduce DT_FOREACH_REG and DT_INST_FOREACH_REG macros to enable
iteration over reg entries in devicetree nodes by invoking a user-
supplied macro per entry. Add support for macros accepting a
separator and variadic arguments with the new DT_FOREACH_REG_SEP,
DT_FOREACH_REG_VARGS, and DT_FOREACH_REG_SEP_VARGS macros, as well
as their DT_INST_ variants.
The DT_FOREACH_REG macro mirrors the behavior of the ranges property.
Update the devicetree macro generation logic in gen_defines.py to
emit the new macro variants. Document the additions by expanding the
Augmented Backus-Naur Form grammar in macros.bnf. Add detailed
comments with usage examples and parameter details for all new macros.
Expand test coverage with new overlay nodes and dedicated tests to
verify macro correctness and behavior, across various node scenarios
including multi-register, single-register, and nodes lacking reg
properties.
Signed-off-by: Oleksii Moisieiev <oleksii_moisieiev@epam.com>
Signed-off-by: Svitlana Drozd <svitlana_drozd@epam.com>
The runner always selected elf_file, ignoring hex_file and bin_file from
RunnerConfig. This broke MCUBoot support since the bootloader
requires hex/bin format and the build system sets hex_file to
signed images (zephyr.signed.hex).
Fixes commit 3c7d973 ("west: runners: probe-rs: Add enhanced
functionality")
Signed-off-by: Michał Bogdziewicz <michal@bogdziewicz.xyz>
Add Fish shell completion entries that are already present in the
Bash completion script but were missing from the Fish one:
- Add __zephyr_west_complete_shield for cached shield completion
- Add --shield argument completion to west build
- Add completion entries for the west shields subcommand
- Add completion entries for the west twister subcommand
Fixes#73128
Signed-off-by: Nancy Sangani <9d.24.nancy.sangani@gmail.com>
The OpenRISC CPU architecture is signified by the CONFIG_OPENRISC Kconfig
option. This patch adds this information to the log database ARCHS table.
Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
When the `west rtt --runner=jlink` command is executed, the client is
attached to the channel number 0 by default.. However, if several
subsystems are configured to use different RTT channels, e.g. shell to
the channel 0 and logging to the channel 1, it's currently impossible
to attach to any channel other than 0.
The `west rtt` command for the `jlink` runner is extended by a new
argument called `--rtt-channel=<channel>` where `<channel>` is an
integer, e.g. 0, 1, etc. Usage example:
west rtt --runner=jlink --rtt-channel=1
When the channel is specified, once the client is connected, it sends the
following configuration sequence:
$$SEGGER_TELNET_ConfigStr=RTTCh;<channel>$$
This configuration sequence instructs the server to send data associated
only to the given channel. This string must be send within 100 ms after
establishing a connection, otherwise it would be ignored.
The following is an example of a configuration where shell uses channel 0
and logging - channel 1:
CONFIG_SHELL=y
CONFIG_SHELL_BACKEND_RTT=y
CONFIG_SHELL_BACKEND_RTT_BUFFER=0
CONFIG_SHELL_BACKEND_SERIAL=n
CONFIG_SHELL_LOG_BACKEND=n
CONFIG_LOG=y
CONFIG_LOG_BACKEND_RTT=y
CONFIG_LOG_BACKEND_RTT_BUFFER=1
CONFIG_LOG_BACKEND_UART=n
Signed-off-by: Ilia Kharin <akscram@gmail.com>
Add a custom Kconfig preprocessor option to obtain the highest IRQn on a
controller. This can be useful to compute CONFIG_NUM_IRQS automatically at
build time.
Signed-off-by: Mathieu Choplain <mathieu.choplain-ext@st.com>
Allow fallback URLs to select a different back-end.
The "url:" field can now take a list of URLs so that if an
URL fails, the next one can be fetched (i.e. a remote host is down).
Error handling is refactored to let blobs.py call os.exit(), with a
new ZephyrBlobException used for the purpose of catching blob-fetching
related errors, and still allow i.e. KeyboardInterrupt to be raised.
Signed-off-by: Josuah Demangeon <me@josuah.net>
The spec makes it clear that node address can be omitted from node path
if not unambiguous see 2.2.3. Path Names
> A unit address may be omitted if the full path to the node is
unambiguous.
e.g.
````
/ {
foo@10 {};
}
```
both paths -> /foo and /foo@10 should work.
Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
IMO the spec is clear about the case insensitivity. The node address
must be match the reg value see 2.2.1.1. Node Name Requirements
> The unit-address must match the first address specified in the reg
property of the node.
reg property is a prop-encoded array and by definition.
reg = <0xA> or reg = <0xa> are the same. hence Both foo@a and foo@A
are the same.
Signed-off-by: Kyle Bonnici <kylebonnici@hotmail.com>
Wrap the picotool sign command (requires recent picotool) to build
signed ELF files (which can be later converted to UF2 as well).
The resulting files boot, yet this has not been tested with actual
Secure Boot yet.
Signed-off-by: Dmitrii Sharshakov <d3dx12.xx@gmail.com>
- monitor_serial() opens handler.log in binary mode (\"wb\") and writes
re-encoded bytes. When the runner (e.g. linkserver for frdm-mcxn947)
produces serial output that is not cleanly decodable as UTF-8, the
decode('utf-8', 'ignore') silently drops bytes and the resulting
handler.log is unreadable.
- Fix by opening handler.log in text mode with explicit UTF-8 encoding,
consistent with BinaryHandler.handle_serial() which uses open(\"w\").
Change the decode error handler from 'ignore' to 'replace' so
corruption becomes visible as replacement characters rather than
silently dropped bytes.
Signed-off-by: Jjateen Gundesha <jjateen97@gmail.com>
