i2s_buf_write() acquires its memory block with K_FOREVER, so on a
multithreaded build the two error codes it documents for that step can
never be produced: -ENOMEM because K_FOREVER does not return it, which
also makes the error branch below the call dead code, and -EAGAIN
because nothing ever times out. An application that exhausts the slab
blocks forever instead of being told. Without CONFIG_MULTITHREADING the
slab treats every timeout as no-wait, so only -EAGAIN is unreachable.
The userspace path has its own copy. z_vrfy_i2s_buf_write() allocates
the same way and then flattens whatever it gets to -ENOMEM, which was
harmless only because that branch was equally unreachable. Both copies
now use SYS_TIMEOUT_MS(), which already maps SYS_FOREVER_MS itself, and
both return the slab's errno unchanged, so the two paths agree.
k_mem_slab_alloc() produces exactly the two documented codes: -ENOMEM
when told not to wait, which is what a configured timeout of 0 becomes,
and -EAGAIN when the wait expires.
One consequence is worth stating rather than leaving to be discovered:
drivers already apply the same configured timeout when enqueueing the
block, so this call can now spend it twice, once acquiring and once
enqueueing. Making it a single end-to-end deadline would need a way to
pass the remaining time into i2s_write(), which the API has no room for
today, so it is documented as a per-stage bound instead.
The in-tree suites are unaffected: the loopback test prefills exactly
NUM_TX_BLOCKS blocks into a slab of NUM_TX_BLOCKS, so every acquisition
succeeds without waiting.
Fixes#113333
Signed-off-by: Hsiu-Chi Tsai <hctsai@linux.com>
Modify the signature of the k_mem_slab_free() function with a new one,
replacing the old void **mem with void *mem as a parameter.
The following function:
void k_mem_slab_free(struct k_mem_slab *slab, void **mem);
has the wrong signature. mem is only used as a regular pointer, so there
is no need to use a double-pointer. The correct signature should be:
void k_mem_slab_free(struct k_mem_slab *slab, void *mem);
The issue with the current signature, although functional, is that it is
extremely confusing. I myself, a veteran Zephyr developer, was confused
by this parameter when looking at it recently.
All in-tree uses of the function have been adapted.
Fixes#61888.
Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
In order to bring consistency in-tree, migrate all drivers to the new
prefix <zephyr/...>. Note that the conversion has been scripted, refer
to #45388 for more details.
Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
The i2s_config structure passed to the i2s_configure() function is
not supposed to be modified by the driver. Similarly, the structure
returned by the i2s_config_get() function is not supposed to be
modified outside the driver.
Decorate the pointers to those structures with the const qualifier
and correct one driver that actually modified the structure passed
to i2s_configure().
Signed-off-by: Andrzej Głąbek <andrzej.glabek@nordicsemi.no>
Now that device_api attribute is unmodified at runtime, as well as all
the other attributes, it is possible to switch all device driver
instance to be constant.
A coccinelle rule is used for this:
@r_const_dev_1
disable optional_qualifier
@
@@
-struct device *
+const struct device *
@r_const_dev_2
disable optional_qualifier
@
@@
-struct device * const
+const struct device *
Fixes#27399
Signed-off-by: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
move i2s.h to drivers/i2s.h and
create a shim for backward-compatibility.
No functional changes to the headers.
A warning in the shim can be controlled with CONFIG_COMPAT_INCLUDES.
Related to #16539
Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Update reserved function names starting with one underscore, replacing
them as follows:
'_k_' with 'z_'
'_K_' with 'Z_'
'_handler_' with 'z_handl_'
'_Cstart' with 'z_cstart'
'_Swap' with 'z_swap'
This renaming is done on both global and those static function names
in kernel/include and include/. Other static function names in kernel/
are renamed by removing the leading underscore. Other function names
not starting with any prefix listed above are renamed starting with
a 'z_' or 'Z_' prefix.
Function names starting with two or three leading underscores are not
automatcally renamed since these names will collide with the variants
with two or three leading underscores.
Various generator scripts have also been updated as well as perf,
linker and usb files. These are
drivers/serial/uart_handlers.c
include/linker/kobject-text.ld
kernel/include/syscall_handler.h
scripts/gen_kobject_list.py
scripts/gen_syscall_header.py
Signed-off-by: Patrik Flykt <patrik.flykt@intel.com>
User mode may now access the read, write, and trigger APIs.
Unlike supervisor mode, memory slabs are not dealt with directly,
the data is always copied.
A new driver API added to fetch the current channel configuration,
used by the system call handlers.
The i2s_sam_ssc driver updated for the new API. CAVS driver not
modified as there is no user mode port to Xtensa yet.
Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
