michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: Remove BT_HEXDUMP_DBG

Browse source 
Replace unnecessary `BT_HEXDUMP_DBG` with `LOG_HEXDUMP_DBG`.

`BT_HEXDUMP_DBG` did an extra cast to `const uint8_t *` on its first
argument. This was probably the reason it was introduced. But the
current definition of `LOG_HEXDUMP_DBG` does this cast for us.

Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no>
This commit is contained in:
Théo Battrel 2022-10-24 11:23:12 +02:00 • committed by Carles Cufí
commit fdd0a26348
22 changed files with 85 additions and 105 deletions
Download patch file Download diff file Expand all files Collapse all files

14
subsys/bluetooth/audio/tbs_client.c
View file

@ -538,7 +538,7 @@ static uint8_t notify_handler(struct bt_conn *conn,
BT_DBG("Index %u", inst_index);
BT_HEXDUMP_DBG(data, length, "notify handler value");
LOG_HEXDUMP_DBG(data, length, "notify handler value");
if (handle == tbs_inst->call_state_sub_params.value_handle) {
call_state_notify_handler(conn, tbs_inst, data, length);
@ -700,7 +700,7 @@ static uint8_t read_technology_cb(struct bt_conn *conn, uint8_t err,
if (err != 0) {
BT_DBG("err: 0x%02X", err);
} else if (data != NULL) {
BT_HEXDUMP_DBG(data, length, "Data read");
LOG_HEXDUMP_DBG(data, length, "Data read");
if (length == sizeof(technology)) {
(void)memcpy(&technology, data, length);
BT_DBG("%s (0x%02x)", bt_tbs_technology_str(technology), technology);
@ -768,7 +768,7 @@ static uint8_t read_signal_strength_cb(struct bt_conn *conn, uint8_t err,
if (err != 0) {
BT_DBG("err: 0x%02X", err);
} else if (data != NULL) {
BT_HEXDUMP_DBG(data, length, "Data read");
LOG_HEXDUMP_DBG(data, length, "Data read");
if (length == sizeof(signal_strength)) {
(void)memcpy(&signal_strength, data, length);
BT_DBG("0x%02x", signal_strength);
@ -805,7 +805,7 @@ static uint8_t read_signal_interval_cb(struct bt_conn *conn, uint8_t err,
if (err != 0) {
BT_DBG("err: 0x%02X", err);
} else if (data != NULL) {
BT_HEXDUMP_DBG(data, length, "Data read");
LOG_HEXDUMP_DBG(data, length, "Data read");
if (length == sizeof(signal_interval)) {
(void)memcpy(&signal_interval, data, length);
BT_DBG("0x%02x", signal_interval);
@ -905,7 +905,7 @@ static uint8_t read_ccid_cb(struct bt_conn *conn, uint8_t err,
if (err != 0) {
BT_DBG("err: 0x%02X", err);
} else if (data != NULL) {
BT_HEXDUMP_DBG(data, length, "Data read");
LOG_HEXDUMP_DBG(data, length, "Data read");
if (length == sizeof(ccid)) {
(void)memcpy(&ccid, data, length);
BT_DBG("0x%02x", ccid);
@ -942,7 +942,7 @@ static uint8_t read_status_flags_cb(struct bt_conn *conn, uint8_t err,
if (err != 0) {
BT_DBG("err: 0x%02X", err);
} else if (data != NULL) {
BT_HEXDUMP_DBG(data, length, "Data read");
LOG_HEXDUMP_DBG(data, length, "Data read");
if (length == sizeof(status_flags)) {
(void)memcpy(&status_flags, data, length);
BT_DBG("0x%04x", status_flags);
@ -1092,7 +1092,7 @@ static uint8_t read_optional_opcodes_cb(struct bt_conn *conn, uint8_t err,
if (err != 0) {
BT_DBG("err: 0x%02X", err);
} else if (data != NULL) {
BT_HEXDUMP_DBG(data, length, "Data read");
LOG_HEXDUMP_DBG(data, length, "Data read");
if (length == sizeof(optional_opcodes)) {
(void)memcpy(&optional_opcodes, data, length);
BT_DBG("0x%04x", optional_opcodes);