michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: Remove BT_HEXDUMP_DBG

Browse source 
Replace unnecessary `BT_HEXDUMP_DBG` with `LOG_HEXDUMP_DBG`.

`BT_HEXDUMP_DBG` did an extra cast to `const uint8_t *` on its first
argument. This was probably the reason it was introduced. But the
current definition of `LOG_HEXDUMP_DBG` does this cast for us.

Signed-off-by: Théo Battrel <theo.battrel@nordicsemi.no>
This commit is contained in:
Théo Battrel 2022-10-24 11:23:12 +02:00 • committed by Carles Cufí
commit fdd0a26348
22 changed files with 85 additions and 105 deletions
Download patch file Download diff file Expand all files Collapse all files

13
subsys/bluetooth/audio/mpl.c
View file

@ -343,8 +343,7 @@ static uint32_t setup_segments_object(struct mpl_track *track)
seg = seg->next;
}
BT_HEXDUMP_DBG(obj.content->data, obj.content->len,
"Segments Object");
LOG_HEXDUMP_DBG(obj.content->data, obj.content->len, "Segments Object");
BT_DBG("Segments object length: %d", obj.content->len);
} else {
BT_ERR("No seg!");
@ -406,8 +405,7 @@ static uint32_t setup_parent_group_object(struct mpl_group *group)
if (next_size > obj.content->size) {
BT_WARN("Not room for full group in object");
}
BT_HEXDUMP_DBG(obj.content->data, obj.content->len,
"Parent Group Object");
LOG_HEXDUMP_DBG(obj.content->data, obj.content->len, "Parent Group Object");
BT_DBG("Group object length: %d", obj.content->len);
}
return obj.content->len;
@ -439,8 +437,7 @@ static uint32_t setup_group_object(struct mpl_group *group)
if (next_size > obj.content->size) {
BT_WARN("Not room for full group in object");
}
BT_HEXDUMP_DBG(obj.content->data, obj.content->len,
"Group Object");
LOG_HEXDUMP_DBG(obj.content->data, obj.content->len, "Group Object");
BT_DBG("Group object length: %d", obj.content->len);
}
return obj.content->len;
@ -2651,7 +2648,7 @@ static void parse_search(const struct mpl_search *search)
index += sci.len - 1;
BT_DBG("SCI # %d: type: %d", sci_num, sci.type);
BT_HEXDUMP_DBG(sci.param, sci.len-1, "param:");
LOG_HEXDUMP_DBG(sci.param, sci.len - 1, "param:");
sci_num++;
}
}
@ -2677,7 +2674,7 @@ void send_search(const struct mpl_search *search)
BT_WARN("Search too long: %d", search->len);
}
BT_HEXDUMP_DBG(search->search, search->len, "Search");
LOG_HEXDUMP_DBG(search->search, search->len, "Search");
parse_search(search);
}