michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: modem: hl7800: Allow operation without a SIM card

Browse source 
Allow the driver to run if a SIM card is not present.
This allows public HL7800 APIs like firmware updates
to be used even if no network is available.
Remove duplicate query ICCID command.

Signed-off-by: Andrew Hedin <andrew.hedin@lairdconnect.com>
This commit is contained in:
Andrew Hedin 2021-04-13 09:38:41 -05:00 • committed by Anas Nashif
commit fd864c61bb
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
drivers/modem/hl7800.c
View file

@ -501,7 +501,7 @@ struct hl7800_iface_ctx {
char mdm_sn[MDM_HL7800_SERIAL_NUMBER_SIZE]; char mdm_sn[MDM_HL7800_SERIAL_NUMBER_SIZE];
char mdm_network_status[MDM_NETWORK_STATUS_LENGTH]; char mdm_network_status[MDM_NETWORK_STATUS_LENGTH];
char mdm_iccid[MDM_HL7800_ICCID_SIZE]; char mdm_iccid[MDM_HL7800_ICCID_SIZE];
uint8_t mdm_startup_state; enum mdm_hl7800_startup_state mdm_startup_state;
enum mdm_hl7800_radio_mode mdm_rat; enum mdm_hl7800_radio_mode mdm_rat;
char mdm_active_bands_string[MDM_HL7800_LTE_BAND_STR_SIZE]; char mdm_active_bands_string[MDM_HL7800_LTE_BAND_STR_SIZE];
char mdm_bands_string[MDM_HL7800_LTE_BAND_STR_SIZE]; char mdm_bands_string[MDM_HL7800_LTE_BAND_STR_SIZE];
@ -3693,8 +3693,6 @@ static int modem_boot_handler(char *reason)
LOG_ERR("Err waiting for boot: %d, DSR: %u", ret, LOG_ERR("Err waiting for boot: %d, DSR: %u", ret,
ictx.dsr_state); ictx.dsr_state);
return -1; return -1;
} else if (ictx.mdm_startup_state != HL7800_STARTUP_STATE_READY) {
return -1;
} else { } else {
LOG_INF("Modem booted!"); LOG_INF("Modem booted!");
} }
@ -4028,7 +4026,7 @@ reboot:
SEND_COMPLEX_AT_CMD("AT+KGSN=3"); SEND_COMPLEX_AT_CMD("AT+KGSN=3");
/* query SIM ICCID */ /* query SIM ICCID */
SEND_AT_CMD_EXPECT_OK("AT+CCID?"); SEND_AT_CMD_IGNORE_ERROR("AT+CCID?");
/* An empty string is used here so that it doesn't conflict /* An empty string is used here so that it doesn't conflict
* with the APN used in the +CGDCONT command. * with the APN used in the +CGDCONT command.
@ -4079,7 +4077,6 @@ error:
LOG_ERR("Unable to configure modem"); LOG_ERR("Unable to configure modem");
ictx.configured = false; ictx.configured = false;
set_network_state(HL7800_UNABLE_TO_CONFIGURE); set_network_state(HL7800_UNABLE_TO_CONFIGURE);
modem_reset();
/* Kernel will fault with non-zero return value. /* Kernel will fault with non-zero return value.
* Allow other parts of application to run when modem cannot be configured. * Allow other parts of application to run when modem cannot be configured.
*/ */