michaelh/zephyr
1
0
Fork 0
Code Releases Activity

shell: fix index out bound issue

Browse source 
In order to prevent index out of bounds access of the sh->ctx->cmd_buff
array when sh->ctx->cmd_buff_pos is 0, it has been added a check for the
value of sh->ctx->cmd_buff_pos.

This ensures that the array will not be accessed beyond its boundaries.

Signed-off-by: Jungo Lin <jungolin.tw@gmail.com>
This commit is contained in:
Jungo Lin 2024-03-10 10:42:52 +08:00 • committed by Carles Cufí
commit fa716d9842
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
subsys/shell/shell.c
View file

@ -288,8 +288,8 @@ static bool tab_prepare(const struct shell *sh,
/* If last command is not completed (followed by space) it is treated /* If last command is not completed (followed by space) it is treated
* as uncompleted one. * as uncompleted one.
*/ */
int space = isspace((int)sh->ctx->cmd_buff[ int space = (sh->ctx->cmd_buff_pos > 0) ?
sh->ctx->cmd_buff_pos - 1]); isspace((int)sh->ctx->cmd_buff[sh->ctx->cmd_buff_pos - 1]) : 0;
/* root command completion */ /* root command completion */
if ((*argc == 0) || ((space == 0) && (*argc == 1))) { if ((*argc == 0) || ((space == 0) && (*argc == 1))) {