michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: spi: sifive: fix bug of transferring multiple bufs

Browse source 
This patch fixes a bug of SPI driver for SiFive FE310.
Current implementation sends/receives only first buffer even if
an user passed two or more struct spi_buf to driver.

Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
This commit is contained in:
Katsuhiro Suzuki 2021-04-28 03:55:15 +09:00 • committed by Kumar Gala
commit f8e9b505c9
1 changed files with 16 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

30
drivers/spi/spi_sifive.c
View file

@ -115,27 +115,29 @@ uint16_t spi_sifive_recv(const struct device *dev)
void spi_sifive_xfer(const struct device *dev, const bool hw_cs_control)
{
struct spi_context *ctx = &SPI_DATA(dev)->ctx;
uint16_t txd, rxd;
uint32_t send_len = spi_context_longest_current_buf(ctx);
for (uint32_t i = 0; i < send_len; i++) {
do {
/* Send a frame */
if (i < ctx->tx_len) {
spi_sifive_send(dev, (uint16_t) (ctx->tx_buf)[i]);
if (spi_context_tx_buf_on(ctx)) {
txd = *ctx->tx_buf;
} else {
/* Send dummy bytes */
spi_sifive_send(dev, 0);
txd = 0U;
}
spi_sifive_send(dev, txd);
spi_context_update_tx(ctx, 1, 1);
/* Receive a frame */
if (i < ctx->rx_len) {
ctx->rx_buf[i] = (uint8_t) spi_sifive_recv(dev);
} else {
/* Discard returned value */
spi_sifive_recv(dev);
rxd = spi_sifive_recv(dev);
if (spi_context_rx_buf_on(ctx)) {
*ctx->rx_buf = rxd;
}
}
spi_context_update_rx(ctx, 1, 1);
} while (spi_context_tx_on(ctx) || spi_context_rx_on(ctx));
/* Deassert the CS line */
if (!hw_cs_control) {