michaelh/zephyr
1
0
Fork 0
Code Releases Activity

subsys: fs: fcb: fix - crc write size not aligned

Browse source 
This is bug-fix for issue #7311
FCB: CRC write size in append_finish doesn't honor
flash min write size

This patch changes write size to the minimum supported
write size.


Signed-off-by: Andrzej Puzdrowski <andrzej.puzdrowski@nordicsemi.no>
This commit is contained in:
Andrzej Puzdrowski 2018-05-04 11:03:14 +02:00 • committed by Anas Nashif
commit f4dcb4593d
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
subsys/fs/fcb/fcb_append.c
View file

@ -6,6 +6,7 @@
*/ */
#include <stddef.h> #include <stddef.h>
#include <string.h>
#include "fcb.h" #include "fcb.h"
#include "fcb_priv.h" #include "fcb_priv.h"
@ -115,16 +116,18 @@ int
fcb_append_finish(struct fcb *fcb, struct fcb_entry *loc) fcb_append_finish(struct fcb *fcb, struct fcb_entry *loc)
{ {
int rc; int rc;
u8_t crc8; u8_t crc8[fcb->f_align];
off_t off; off_t off;
rc = fcb_elem_crc8(fcb, loc, &crc8); memset(crc8, 0xFF, sizeof(crc8));
rc = fcb_elem_crc8(fcb, loc, &crc8[0]);
if (rc) { if (rc) {
return rc; return rc;
} }
off = loc->fe_data_off + fcb_len_in_flash(fcb, loc->fe_data_len); off = loc->fe_data_off + fcb_len_in_flash(fcb, loc->fe_data_len);
rc = fcb_flash_write(fcb, loc->fe_sector, off, &crc8, sizeof(crc8)); rc = fcb_flash_write(fcb, loc->fe_sector, off, crc8, fcb->f_align);
if (rc) { if (rc) {
return FCB_ERR_FLASH; return FCB_ERR_FLASH;
} }