michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: wifi: eswifi: fix coverity Out-of-bounds access errors

Browse source 
There are multiple CID errors all based on the test of
'socket > ESWIFI_OFFLOAD_MAX_SOCKETS'. The test needs to
be '>=' in all cases.

Fixes: #27138
Fixes: #27139
Fixes: #27140
Fixes: #27141
Fixes: #27142
Fixes: #27143

Signed-off-by: David Leach <david.leach@nxp.com>
This commit is contained in:
David Leach 2020-07-27 13:30:17 -05:00 • committed by Anas Nashif
commit f4caf7b890
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
drivers/wifi/eswifi/eswifi_socket_offload.c
View file

@ -58,7 +58,7 @@ static int eswifi_socket_connect(void *obj, const struct sockaddr *addr,
int ret;
if ((addrlen == 0) || (addr == NULL) ||
(sock > ESWIFI_OFFLOAD_MAX_SOCKETS)) {
(sock >= ESWIFI_OFFLOAD_MAX_SOCKETS)) {
return -EINVAL;
}
@ -97,7 +97,7 @@ static int __eswifi_socket_accept(void *obj, struct sockaddr *addr,
int ret;
if ((addrlen == NULL) || (addr == NULL) ||
(sock > ESWIFI_OFFLOAD_MAX_SOCKETS)) {
(sock >= ESWIFI_OFFLOAD_MAX_SOCKETS)) {
return -EINVAL;
}
@ -294,7 +294,7 @@ static ssize_t eswifi_socket_recv(void *obj, void *buf, size_t max_len,
struct net_pkt *pkt;
if ((max_len == 0) || (buf == NULL) ||
(sock > ESWIFI_OFFLOAD_MAX_SOCKETS)) {
(sock >= ESWIFI_OFFLOAD_MAX_SOCKETS)) {
return -EINVAL;
}
@ -356,7 +356,7 @@ static int eswifi_socket_close(int sock)
struct net_pkt *pkt;
int ret;
if (sock > ESWIFI_OFFLOAD_MAX_SOCKETS) {
if (sock >= ESWIFI_OFFLOAD_MAX_SOCKETS) {
return -EINVAL;
}
@ -435,7 +435,7 @@ static int eswifi_socket_poll(struct zsock_pollfd *fds, int nfds, int msecs)
return -1;
}
if (sock > ESWIFI_OFFLOAD_MAX_SOCKETS) {
if (sock >= ESWIFI_OFFLOAD_MAX_SOCKETS) {
errno = EINVAL;
return -1;
}
@ -460,7 +460,7 @@ static int eswifi_socket_bind(void *obj, const struct sockaddr *addr,
int ret;
if ((addrlen == 0) || (addr == NULL) ||
(sock > ESWIFI_OFFLOAD_MAX_SOCKETS)) {
(sock >= ESWIFI_OFFLOAD_MAX_SOCKETS)) {
return -EINVAL;
}