michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: Controller: Make aa in radio_aa_set const

Browse source 
Make the aa argument const to solve a Coverity issue
that assumes that any value that is being byteswapped
is tainted. Making the argument const should avoid
this assumption from Coverity.

Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
This commit is contained in:
Emil Gydesen 2023-10-04 10:29:55 +02:00 • committed by Carles Cufí
commit f4221d66c1
4 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/radio/radio.c
View file

@ -382,7 +382,7 @@ void radio_whiten_iv_set(uint32_t iv)
RADIO_PCNF1_WHITEEN_Msk; RADIO_PCNF1_WHITEEN_Msk;
} }
void radio_aa_set(uint8_t *aa) void radio_aa_set(const uint8_t *aa)
{ {
NRF_RADIO->TXADDRESS = NRF_RADIO->TXADDRESS =
(((0UL) << RADIO_TXADDRESS_TXADDRESS_Pos) & (((0UL) << RADIO_TXADDRESS_TXADDRESS_Pos) &

2
subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/radio/radio.h
View file

@ -70,7 +70,7 @@ int8_t radio_tx_power_max_get(void);
int8_t radio_tx_power_floor(int8_t power); int8_t radio_tx_power_floor(int8_t power);
void radio_freq_chan_set(uint32_t chan); void radio_freq_chan_set(uint32_t chan);
void radio_whiten_iv_set(uint32_t iv); void radio_whiten_iv_set(uint32_t iv);
void radio_aa_set(uint8_t *aa); void radio_aa_set(const uint8_t *aa);
void radio_pkt_configure(uint8_t bits_len, uint8_t max_len, uint8_t flags); void radio_pkt_configure(uint8_t bits_len, uint8_t max_len, uint8_t flags);
void radio_pkt_rx_set(void *rx_packet); void radio_pkt_rx_set(void *rx_packet);
void radio_pkt_tx_set(void *tx_packet); void radio_pkt_tx_set(void *tx_packet);

2
subsys/bluetooth/controller/ll_sw/openisa/hal/RV32M1/radio/radio.c
View file

@ -684,7 +684,7 @@ void radio_whiten_iv_set(uint32_t iv)
GENFSK->WHITEN_SZ_THR |= GENFSK_WHITEN_SZ_THR_WHITEN_SZ_THR(0); GENFSK->WHITEN_SZ_THR |= GENFSK_WHITEN_SZ_THR_WHITEN_SZ_THR(0);
} }
void radio_aa_set(uint8_t *aa) void radio_aa_set(const uint8_t *aa)
{ {
/* Configure Access Address detection using NETWORK ADDRESS 0 */ /* Configure Access Address detection using NETWORK ADDRESS 0 */
GENFSK->NTW_ADR_0 = *((uint32_t *)aa); GENFSK->NTW_ADR_0 = *((uint32_t *)aa);

2
subsys/bluetooth/controller/ll_sw/openisa/hal/RV32M1/radio/radio.h
View file

@ -20,7 +20,7 @@ void radio_tx_power_set(uint32_t power);
void radio_tx_power_max_set(void); void radio_tx_power_max_set(void);
void radio_freq_chan_set(uint32_t chan); void radio_freq_chan_set(uint32_t chan);
void radio_whiten_iv_set(uint32_t iv); void radio_whiten_iv_set(uint32_t iv);
void radio_aa_set(uint8_t *aa); void radio_aa_set(const uint8_t *aa);
void radio_pkt_configure(uint8_t bits_len, uint8_t max_len, uint8_t flags); void radio_pkt_configure(uint8_t bits_len, uint8_t max_len, uint8_t flags);
void radio_pkt_rx_set(void *rx_packet); void radio_pkt_rx_set(void *rx_packet);
void radio_pkt_tx_set(void *tx_packet); void radio_pkt_tx_set(void *tx_packet);