michaelh/zephyr
1
0
Fork 0
Code Releases Activity

os: lib: bin2hex: fix memory overwrite

Browse source 
Destination buffer size could be too small by one,
but null termination is still written. This could cause an
overwrite in contiguous memory without notice.

Signed-off-by: Rico Ganahl <rico.ganahl@bytesatwork.ch>
This commit is contained in:
Rico Ganahl 2022-03-28 13:07:48 +02:00 • committed by Marti Bolivar
commit f2affbd973
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
lib/os/hex.c
View file

@ -39,7 +39,7 @@ int hex2char(uint8_t x, char *c)
size_t bin2hex(const uint8_t *buf, size_t buflen, char *hex, size_t hexlen)
{
if ((hexlen + 1) < buflen * 2) {
if (hexlen < (buflen * 2 + 1)) {
return 0;
}