michaelh/zephyr
1
0
Fork 0
Code Releases Activity

net: tcp: Deprecate CONFIG_NET_TCP_ACK_TIMEOUT

Browse source 
Deprecate CONFIG_NET_TCP_ACK_TIMEOUT as it is redundant with the
combination of CONFIG_NET_TCP_INIT_RETRANSMISSION_TIMEOUT and
CONFIG_NET_TCP_RETRY_COUNT. The total retransmission timeout (i. e.
waiting for ACK) should depend on the individual retransmission timeout
and retry count, having separate config is simply ambiguous and
confusing for users.

Moreover, the config was currently only used during TCP handshake, and
for that purpose we could use the very same timeout that is used for the
FIN timeout. Therefore, repurpose the fin_timeout_ms to be a generic,
maximum timeout at the TCP stack.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
This commit is contained in:
Robert Lubos 2024-03-26 11:34:29 +01:00 • committed by Anas Nashif
commit f211cd6345
4 changed files with 22 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

1
tests/net/all/prj.conf
View file

@ -126,7 +126,6 @@ CONFIG_NET_MAX_ROUTERS=3
CONFIG_NET_TCP=y
CONFIG_NET_TCP_LOG_LEVEL_DBG=y
CONFIG_NET_TCP_TIME_WAIT_DELAY=20000
CONFIG_NET_TCP_ACK_TIMEOUT=30
CONFIG_NET_TCP_CHECKSUM=y
CONFIG_NET_TCP_INIT_RETRANSMISSION_TIMEOUT=400
CONFIG_NET_TCP_RETRY_COUNT=10