From f0d0e01b455be960223e5ddb1eecf70900a96e20 Mon Sep 17 00:00:00 2001 From: Peter Bigot Date: Fri, 5 Mar 2021 06:09:06 -0600 Subject: [PATCH] tests: kernel: work: fix unchecked return values Coverity wants these to be checked in a few places where the check was elided. Signed-off-by: Peter Bigot --- tests/kernel/workq/work/src/main.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/kernel/workq/work/src/main.c b/tests/kernel/workq/work/src/main.c index ac1375f45ed..0ee36f9bd24 100644 --- a/tests/kernel/workq/work/src/main.c +++ b/tests/kernel/workq/work/src/main.c @@ -160,7 +160,7 @@ static inline void async_release(void) static void rel_handler(struct k_work *work) { - k_sem_take(&rel_sem, K_FOREVER); + (void)k_sem_take(&rel_sem, K_FOREVER); counter_handler(work); } @@ -360,7 +360,8 @@ static void test_1cpu_sync_queue(void) zassert_equal(coophi_counter(), 0, NULL); /* Wait for then verify finish */ - k_sem_take(&sync_sem, K_FOREVER); + rc = k_sem_take(&sync_sem, K_FOREVER); + zassert_equal(rc, 0, NULL); zassert_equal(coophi_counter(), 1, NULL); } @@ -391,14 +392,16 @@ static void test_1cpu_reentrant_queue(void) /* Release the first submission. */ handler_release(); - k_sem_take(&sync_sem, K_FOREVER); + rc = k_sem_take(&sync_sem, K_FOREVER); + zassert_equal(rc, 0, NULL); zassert_equal(coophi_counter(), 1, NULL); /* Confirm the second submission was redirected to the running * queue to avoid re-entrancy problems. */ handler_release(); - k_sem_take(&sync_sem, K_FOREVER); + rc = k_sem_take(&sync_sem, K_FOREVER); + zassert_equal(rc, 0, NULL); zassert_equal(coophi_counter(), 2, NULL); }