From f08045f077c4b1c996ecb9d17a807590027c2a7d Mon Sep 17 00:00:00 2001 From: Markus Becker Date: Mon, 15 Jun 2020 16:55:50 +0200 Subject: [PATCH] settings: Fix uninitialised variables When compiling the settings subsystems, I was getting the following compiler warning: ``` /home/markus/src/wrp-n4m/zephyr/subsys/settings/src/settings_line.c: In function 'settings_line_cmp': /home/markus/src/wrp-n4m/zephyr/subsys/settings/src/settings_line.c:477:6: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized] 477 | int rc; | ^~ /home/markus/src/wrp-n4m/zephyr/subsys/settings/src/settings_line.c: In function 'settings_line_entry_copy': /home/markus/src/wrp-n4m/zephyr/subsys/settings/src/settings_line.c:453:9: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized] 453 | return rc; ``` This patch fixes the warning. Signed-off-by: Markus Becker --- subsys/settings/src/settings_line.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/subsys/settings/src/settings_line.c b/subsys/settings/src/settings_line.c index 437d8fbd85c..d4628b728d5 100644 --- a/subsys/settings/src/settings_line.c +++ b/subsys/settings/src/settings_line.c @@ -226,7 +226,7 @@ static int settings_line_raw_read_until(off_t seek, char *out, size_t len_req, size_t exp_size, read_size; uint8_t rbs = settings_io_cb.rwbs; off_t off; - int rc; + int rc = -EINVAL; if (len_req == 0) { return -EINVAL; @@ -428,7 +428,7 @@ int settings_line_name_read(char *out, size_t len_req, size_t *len_read, int settings_line_entry_copy(void *dst_ctx, off_t dst_off, void *src_ctx, off_t src_off, size_t len) { - int rc; + int rc = -EINVAL; char buf[16]; size_t chunk_size; @@ -474,7 +474,7 @@ static int settings_line_cmp(char const *val, size_t val_len, size_t len_read, exp_len; size_t rem; char buf[16]; - int rc; + int rc = -EINVAL; off_t off = 0; if (val_len == 0) {