michaelh/zephyr
1
0
Fork 0
Code Releases Activity

settings: Fix uninitialised variables

Browse source 
When compiling the settings subsystems, I was getting the following
compiler warning:

```
/home/markus/src/wrp-n4m/zephyr/subsys/settings/src/settings_line.c: In function 'settings_line_cmp':
/home/markus/src/wrp-n4m/zephyr/subsys/settings/src/settings_line.c:477:6: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
  477 |  int rc;
      |      ^~
/home/markus/src/wrp-n4m/zephyr/subsys/settings/src/settings_line.c: In function 'settings_line_entry_copy':
/home/markus/src/wrp-n4m/zephyr/subsys/settings/src/settings_line.c:453:9: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
  453 |  return rc;
```

This patch fixes the warning.

Signed-off-by: Markus Becker <markus.becker@tridonic.com>
This commit is contained in:
Markus Becker 2020-06-15 16:55:50 +02:00 • committed by Jukka Rissanen
commit f08045f077
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
subsys/settings/src/settings_line.c
View file

@ -226,7 +226,7 @@ static int settings_line_raw_read_until(off_t seek, char *out, size_t len_req,
size_t exp_size, read_size;
uint8_t rbs = settings_io_cb.rwbs;
off_t off;
int rc;
int rc = -EINVAL;
if (len_req == 0) {
return -EINVAL;
@ -428,7 +428,7 @@ int settings_line_name_read(char *out, size_t len_req, size_t *len_read,
int settings_line_entry_copy(void *dst_ctx, off_t dst_off, void *src_ctx,
off_t src_off, size_t len)
{
int rc;
int rc = -EINVAL;
char buf[16];
size_t chunk_size;
@ -474,7 +474,7 @@ static int settings_line_cmp(char const *val, size_t val_len,
size_t len_read, exp_len;
size_t rem;
char buf[16];
int rc;
int rc = -EINVAL;
off_t off = 0;
if (val_len == 0) {