michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: Controller: Fix multiple peripheral connection deadlock

Browse source 
Fix deadlock in multiple peripheral connection in a device
due to redundant double reservation of node rx buffer during
crossover scenario in Data Length Update procedure.

Data Length Update resize state was reset back to response
wait state when peripheral received an acknowledgment to
local initiated Data Length Request PDU after having already
transitioned to resize state.

Implementation is designed to transition to resize state
under both Data Length Response reception and crossover
scenario of Data Length Request reception when procedure is
local initiated.

Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
This commit is contained in:
Vinayak Kariappa Chettimada 2021-09-26 14:49:42 +05:30 • committed by Carles Cufí
commit f07763640e
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
subsys/bluetooth/controller/ll_sw/ull_conn.c
View file

@ -5903,7 +5903,9 @@ static inline void ctrl_tx_ack(struct ll_conn *conn, struct node_tx **tx,
#if defined(CONFIG_BT_CTLR_DATA_LENGTH) #if defined(CONFIG_BT_CTLR_DATA_LENGTH)
case PDU_DATA_LLCTRL_TYPE_LENGTH_REQ: case PDU_DATA_LLCTRL_TYPE_LENGTH_REQ:
/* wait for response */ /* wait for response */
conn->llcp_length.state = LLCP_LENGTH_STATE_RSP_WAIT; if (conn->llcp_length.state == LLCP_LENGTH_STATE_REQ_ACK_WAIT) {
conn->llcp_length.state = LLCP_LENGTH_STATE_RSP_WAIT;
}
break; break;
case PDU_DATA_LLCTRL_TYPE_LENGTH_RSP: case PDU_DATA_LLCTRL_TYPE_LENGTH_RSP: