michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers: sensor: lsm6dsl: improve driver initialization

Browse source 
Take into account the return code of the bus_init function
and propagate codes from the init* functions to the user
instead of hardcoded -EIO. While at it set the ERROR
level message to the logs.

Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
This commit is contained in:
Bartosz Bilas 2021-11-08 12:07:35 +01:00 • committed by Maureen Helm
commit ee95b5317a
1 changed files with 17 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

26
drivers/sensor/lsm6dsl/lsm6dsl.c
View file

@ -779,26 +779,34 @@ static int lsm6dsl_init_chip(const struct device *dev)
static int lsm6dsl_init(const struct device *dev)
{
int ret;
const struct lsm6dsl_config * const config = dev->config;
config->bus_init(dev);
ret = config->bus_init(dev);
if (ret < 0) {
LOG_ERR("Failed to initialize sensor bus");
return ret;
}
if (lsm6dsl_init_chip(dev) < 0) {
LOG_DBG("failed to initialize chip");
return -EIO;
ret = lsm6dsl_init_chip(dev);
if (ret < 0) {
LOG_ERR("Failed to initialize chip");
return ret;
}
#ifdef CONFIG_LSM6DSL_TRIGGER
if (lsm6dsl_init_interrupt(dev) < 0) {
ret = lsm6dsl_init_interrupt(dev);
if (ret < 0) {
LOG_ERR("Failed to initialize interrupt.");
return -EIO;
return ret;
}
#endif
#ifdef CONFIG_LSM6DSL_SENSORHUB
if (lsm6dsl_shub_init_external_chip(dev) < 0) {
LOG_DBG("failed to initialize external chip");
return -EIO;
ret = lsm6dsl_shub_init_external_chip(dev);
if (ret < 0) {
LOG_ERR("Failed to initialize external chip");
return ret;
}
#endif