michaelh/zephyr
1
0
Fork 0
Code Releases Activity

tests: logging: log_core: Extended test_log_strdup_gc

Browse source 
Extended test to pass address within strdup buffer but with
different format specifier (not string). That should not trigger
string buffer freeing. If it does system may collapse (e.g. cortex-m0
may use unaligned access).

Signed-off-by: Krzysztof Chruscinski <krzysztof.chruscinski@nordicsemi.no>
This commit is contained in:
Krzysztof Chruscinski 2019-12-12 11:20:32 +01:00 • committed by Anas Nashif
commit ee14a49e91
1 changed files with 9 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
tests/subsys/logging/log_core/src/log_core_test.c
View file

@ -329,16 +329,21 @@ static void test_log_from_declared_module(void)
static void test_log_strdup_gc(void) static void test_log_strdup_gc(void)
{ {
char test_str[] = "test string"; char test_str[] = "test string";
char *dstr;
log_setup(false); log_setup(false);
BUILD_ASSERT_MSG(CONFIG_LOG_STRDUP_BUF_COUNT == 1, BUILD_ASSERT_MSG(CONFIG_LOG_STRDUP_BUF_COUNT == 1,
"Test assumes certain configuration"); "Test assumes certain configuration");
backend1_cb.check_strdup = true;
backend1_cb.exp_strdup[0] = true; backend1_cb.exp_strdup[0] = true;
backend1_cb.exp_strdup[1] = false; backend1_cb.exp_strdup[1] = false;
LOG_INF("%s", log_strdup(test_str)); dstr = log_strdup(test_str);
/* test if message freeing is not fooled by using value within strdup
* buffer pool but with different format specifier.
*/
LOG_INF("%s %p", dstr, dstr + 1);
LOG_INF("%s", log_strdup(test_str)); LOG_INF("%s", log_strdup(test_str));
while (log_process(false)) { while (log_process(false)) {
@ -442,7 +447,8 @@ static void log_n_messages(u32_t n_msg, u32_t exp_dropped)
} }
zassert_equal(backend1_cb.total_drops, exp_dropped, zassert_equal(backend1_cb.total_drops, exp_dropped,
"Unexpected log msg dropped"); "Unexpected log msg dropped %d (expected %d)",
backend1_cb.total_drops, exp_dropped);
} }