michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kconfig: Replace some single-symbol 'if's with 'depends on'

Browse source 
I think people might be reading differences into 'if' and 'depends on'
that aren't there, like maybe 'if' being needed to "hide" a symbol,
while 'depends on' just adds a dependency.

There are no differences between 'if' and 'depends on'. 'if' is just a
shorthand for 'depends on'. They work the same when it comes to creating
implicit menus too.

The way symbols get "hidden" is through their dependencies not being
satisfied ('if'/'depends on' get copied up as a dependency on the
prompt).

Since 'if' and 'depends on' are the same, an 'if' with just a single
symbol in it can be replaced with a 'depends on'. IMO, it's best to
avoid 'if' there as a style choice too, because it confuses people into
thinking there's deep Kconfig magic going on that requires 'if'.

Going for 'depends on' can also remove some nested 'if's, which
generates nicer symbol information and docs, because nested 'if's really
are so simple/dumb that they just add the dependencies from both 'if's
to all symbols within.

Replace a bunch of single-symbol 'if's with 'depends on' to despam the
Kconfig files a bit and make it clearer how things work. Also do some
other minor related dependency refactoring.

The replacement isn't complete. Will fix up the rest later. Splitting it
a bit to make it more manageable.

(Everything above is true for choices, menus, and comments as well.)

Detected by tweaking the Kconfiglib parsing code. It's impossible to
detect after parsing, because 'if' turns into 'depends on'.

Signed-off-by: Ulf Magnusson <Ulf.Magnusson@nordicsemi.no>
This commit is contained in:
Ulf Magnusson 2020-02-08 03:45:50 +01:00 • committed by Anas Nashif
commit eddd98f811
53 changed files with 90 additions and 272 deletions
Download patch file Download diff file Expand all files Collapse all files

5
subsys/testsuite/Kconfig
View file

@ -45,17 +45,16 @@ config COVERAGE
For more information see
https://docs.zephyrproject.org/latest/guides/coverage.html
if COVERAGE
config COVERAGE_GCOV
bool "Create Coverage data from hardware platform"
depends on !NATIVE_APPLICATION
default y
depends on COVERAGE
depends on !NATIVE_APPLICATION
help
This option will select the custom gcov library. The reports will
be available over serial. This serial dump can be passed to
gen_gcov_files.py which creates the required .gcda files. These
can be read by gcov utility. For more details see gcovr.com .
endif
config COVERAGE_DUMP
bool "Dump coverage data on exit"

5
subsys/testsuite/ztest/Kconfig
View file

@ -62,12 +62,9 @@ config ZTEST_MOCKING
Enable mocking support for Ztest. This allows the test to set
return values and expected parameters to functions.
if ZTEST_MOCKING
config ZTEST_PARAMETER_COUNT
int "Count of parameters or return values reserved"
default 1
depends on ZTEST_MOCKING
help
Maximum amount of concurrent return values / expected parameters.
endif # ZTEST_MOCKING