michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kernel shell, stacks shell commands: iterate unlocked on SMP

Browse source 
call k_thread_foreach_unlocked to avoid assertions caused
by calling shell_print while holding a global lock

Signed-off-by: Maxim Adelman <imax@meta.com>
This commit is contained in:
Maxim Adelman 2023-06-14 11:33:14 -04:00 • committed by Anas Nashif
commit ecf2cb5932
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
subsys/shell/modules/kernel_service.c
View file

@ -164,7 +164,12 @@ static int cmd_kernel_threads(const struct shell *sh,
shell_print(sh, "Scheduler: %u since last call", sys_clock_elapsed());
shell_print(sh, "Threads:");
#ifdef CONFIG_SMP
k_thread_foreach_unlocked(shell_tdata_dump, (void *)sh);
#else
k_thread_foreach(shell_tdata_dump, (void *)sh);
#endif
return 0;
}
@ -208,7 +213,11 @@ static int cmd_kernel_stacks(const struct shell *sh,
memset(pad, ' ', MAX((THREAD_MAX_NAM_LEN - strlen("IRQ 00")), 1));
#ifdef CONFIG_SMP
k_thread_foreach_unlocked(shell_stack_dump, (void *)sh);
#else
k_thread_foreach(shell_stack_dump, (void *)sh);
#endif
/* Placeholder logic for interrupt stack until we have better
* kernel support, including dumping arch-specific exception-related