michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: audio: fix invalid ase state transition

Browse source 
When Receiver Stop Ready operation has completed, the Unicast Server
may request to terminate a CIS and set source ASE state to Qos
configured state immediately. But after CIS disconnected completed,
it will transition source ASE state from Qos Configured to Disabling
state. It's invalid and will cause assert.

we should add Streaming and Enabling state check when CIS disconnected.

Signed-off-by: Hang Fan <fanhang@xiaomi.com>
This commit is contained in:
Hang Fan 2022-12-06 14:03:35 +08:00 • committed by Carles Cufí
commit ebcfa196fc
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
subsys/bluetooth/audio/ascs.c
View file

@ -558,12 +558,14 @@ static void ascs_ep_iso_disconnected(struct bt_audio_ep *ep, uint8_t reason)
/* The ASE state machine goes into different states from this operation
* based on whether it is a source or a sink ASE.
*/
if (ep->dir == BT_AUDIO_DIR_SOURCE) {
ascs_ep_set_state(ep, BT_AUDIO_EP_STATE_DISABLING);
} else {
ascs_ep_set_state(ep, BT_AUDIO_EP_STATE_QOS_CONFIGURED);
if (ep->status.state == BT_AUDIO_EP_STATE_STREAMING ||
ep->status.state == BT_AUDIO_EP_STATE_ENABLING) {
if (ep->dir == BT_AUDIO_DIR_SOURCE) {
ascs_ep_set_state(ep, BT_AUDIO_EP_STATE_DISABLING);
} else {
ascs_ep_set_state(ep, BT_AUDIO_EP_STATE_QOS_CONFIGURED);
}
}
err = bt_audio_stream_iso_listen(stream);
if (err != 0) {
LOG_ERR("Could not make stream listen: %d", err);