michaelh/zephyr
1
0
Fork 0
Code Releases Activity

Bluetooth: shell: Fix 'bt per-adv-data'

Browse source 
ad_len parameter is not length of complete advertising data, but number
of bt_data structs passed to bt_le_per_adv_set_data - we pass only one.

Also memset target buffer before converting hex string so data shorter
than specified will be right-padded with zeroes instead of some
leftovers.

Signed-off-by: Andrzej Kaczmarek <andrzej.kaczmarek@codecoup.pl>
This commit is contained in:
Andrzej Kaczmarek 2021-02-01 17:48:44 +01:00 • committed by Anas Nashif
commit ebb5b9a558
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
subsys/bluetooth/shell/bt.c
View file

@ -1453,6 +1453,7 @@ static int cmd_per_adv_data(const struct shell *shell, size_t argc,
return -EINVAL;
}
memset(hex_data, 0, sizeof(hex_data));
ad_len = hex2bin(argv[1], strlen(argv[1]), hex_data, sizeof(hex_data));
if (!ad_len) {
@ -1464,7 +1465,7 @@ static int cmd_per_adv_data(const struct shell *shell, size_t argc,
ad.type = hex_data[1];
ad.data = &hex_data[2];
err = bt_le_per_adv_set_data(adv, &ad, ad_len);
err = bt_le_per_adv_set_data(adv, &ad, 1);
if (err) {
shell_error(shell,
"Failed to set periodic advertising data (%d)",