From e9cb0ae72a46d45516d99ff61ffbcbba9b2f48e5 Mon Sep 17 00:00:00 2001 From: Adithya Baglody Date: Tue, 16 Oct 2018 11:45:23 +0530 Subject: [PATCH] arch: kernel_arch_func.h: Fix MISRA violation Always compare unsigned interger type with another unsigned integer type. Currently in nios2, posix, riscv32, x86 and xtensa we were comparing the _kernel.nested variable with a signed interger type. Fixed this violation. Signed-off-by: Adithya Baglody --- arch/nios2/include/kernel_arch_func.h | 2 +- arch/posix/include/kernel_arch_func.h | 2 +- arch/riscv32/include/kernel_arch_func.h | 2 +- arch/x86/include/kernel_arch_func.h | 2 +- arch/xtensa/include/kernel_arch_func.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/nios2/include/kernel_arch_func.h b/arch/nios2/include/kernel_arch_func.h index 1ede6009a0a..1bc9059e475 100644 --- a/arch/nios2/include/kernel_arch_func.h +++ b/arch/nios2/include/kernel_arch_func.h @@ -46,7 +46,7 @@ static inline void _IntLibInit(void) /* No special initialization of the interrupt subsystem required */ } -#define _is_in_isr() (_kernel.nested != 0) +#define _is_in_isr() (_kernel.nested != 0U) #ifdef CONFIG_IRQ_OFFLOAD void _irq_do_offload(void); diff --git a/arch/posix/include/kernel_arch_func.h b/arch/posix/include/kernel_arch_func.h index 5e63876264b..50c643d891d 100644 --- a/arch/posix/include/kernel_arch_func.h +++ b/arch/posix/include/kernel_arch_func.h @@ -63,7 +63,7 @@ static inline void _IntLibInit(void) } #endif -#define _is_in_isr() (_kernel.nested != 0) +#define _is_in_isr() (_kernel.nested != 0U) #endif /* _ASMLANGUAGE */ diff --git a/arch/riscv32/include/kernel_arch_func.h b/arch/riscv32/include/kernel_arch_func.h index c1c98e263a0..50f1fc2a8d3 100644 --- a/arch/riscv32/include/kernel_arch_func.h +++ b/arch/riscv32/include/kernel_arch_func.h @@ -48,7 +48,7 @@ FUNC_NORETURN void _NanoFatalErrorHandler(unsigned int reason, const NANO_ESF *esf); -#define _is_in_isr() (_kernel.nested != 0) +#define _is_in_isr() (_kernel.nested != 0U) #ifdef CONFIG_IRQ_OFFLOAD int _irq_do_offload(void); diff --git a/arch/x86/include/kernel_arch_func.h b/arch/x86/include/kernel_arch_func.h index dc874e44457..421f52ab55c 100644 --- a/arch/x86/include/kernel_arch_func.h +++ b/arch/x86/include/kernel_arch_func.h @@ -142,7 +142,7 @@ extern FUNC_NORETURN void _x86_userspace_enter(k_thread_entry_t user_entry, } #endif -#define _is_in_isr() (_kernel.nested != 0) +#define _is_in_isr() (_kernel.nested != 0U) #endif /* _ASMLANGUAGE */ diff --git a/arch/xtensa/include/kernel_arch_func.h b/arch/xtensa/include/kernel_arch_func.h index 16568f51147..59484afec1f 100644 --- a/arch/xtensa/include/kernel_arch_func.h +++ b/arch/xtensa/include/kernel_arch_func.h @@ -122,7 +122,7 @@ static inline void _IntLibInit(void) } #endif -#define _is_in_isr() (_arch_curr_cpu()->nested != 0) +#define _is_in_isr() (_arch_curr_cpu()->nested != 0U) #endif /* _ASMLANGUAGE */