michaelh/zephyr
1
0
Fork 0
Code Releases Activity

kernel: thread: add default case, remove unused break

Browse source 
According to the Zephyr Coding Guideline all switch statements
shall be well-formed. Add a default case with break and comment
to avoid static analysis tool to raise a violation that there is no
default case.
Also, I think, in all cases above no need to use "break",
because they already are using "return".

Found as a coding guideline violation (MISRA R16.1) by static
coding scanning tool.

Signed-off-by: Maksim Masalski <maksim.masalski@intel.com>
This commit is contained in:
Maksim Masalski 2021-06-02 17:00:17 +08:00 • committed by Kumar Gala
commit e9600a75fc
1 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
kernel/thread.c
View file

@ -267,27 +267,24 @@ const char *k_thread_state_str(k_tid_t thread_id)
switch (thread_id->base.thread_state) { switch (thread_id->base.thread_state) {
case 0: case 0:
return ""; return "";
break;
case _THREAD_DUMMY: case _THREAD_DUMMY:
return "dummy"; return "dummy";
break;
case _THREAD_PENDING: case _THREAD_PENDING:
return "pending"; return "pending";
break;
case _THREAD_PRESTART: case _THREAD_PRESTART:
return "prestart"; return "prestart";
break;
case _THREAD_DEAD: case _THREAD_DEAD:
return "dead"; return "dead";
break;
case _THREAD_SUSPENDED: case _THREAD_SUSPENDED:
return "suspended"; return "suspended";
break;
case _THREAD_ABORTING: case _THREAD_ABORTING:
return "aborting"; return "aborting";
break;
case _THREAD_QUEUED: case _THREAD_QUEUED:
return "queued"; return "queued";
default:
/* Add a break, some day when another case gets added at the end,
* this bit of defensive programming will be useful
*/
break; break;
} }
return "unknown"; return "unknown";