michaelh/zephyr
1
0
Fork 0
Code Releases Activity

mgmt: ec_host_cmd: add support for nocache buffers

Browse source 
Some backends use DMA. Usually, DMA doesn't work correctly, when memory
to transfer is cached. Add a config to place the common buffers in the
nocache section.

Signed-off-by: Dawid Niedzwiecki <dawidn@google.com>
This commit is contained in:
Dawid Niedzwiecki 2024-11-22 16:50:02 +01:00 • committed by Benjamin Cabé
commit e9163992cf
2 changed files with 20 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
subsys/mgmt/ec_host_cmd/Kconfig
View file

@ -76,6 +76,15 @@ config EC_HOST_CMD_HANDLER_RX_BUFFER_DEF
help help
The handler defines common rx buffer The handler defines common rx buffer
config EC_HOST_CMD_NOCACHE_BUFFERS
bool "Place RX and TX buffers in __nocache section"
default y if DCACHE && DMA
depends on EC_HOST_CMD_HANDLER_TX_BUFFER_DEF || EC_HOST_CMD_HANDLER_RX_BUFFER_DEF
help
DMA is often use for communication, however it usually requires
uncached memory. Add possibility to place the RX and TX buffers in the
__nocache section.
config EC_HOST_CMD_INITIALIZE_AT_BOOT config EC_HOST_CMD_INITIALIZE_AT_BOOT
bool "Initialize the host command subsystem automacitlly" bool "Initialize the host command subsystem automacitlly"
default y default y

15
subsys/mgmt/ec_host_cmd/ec_host_cmd_handler.c
View file

@ -6,6 +6,7 @@
#include <zephyr/devicetree.h> #include <zephyr/devicetree.h>
#include <zephyr/kernel.h> #include <zephyr/kernel.h>
#include <zephyr/linker/section_tags.h>
#include <zephyr/logging/log.h> #include <zephyr/logging/log.h>
#include <zephyr/mgmt/ec_host_cmd/ec_host_cmd.h> #include <zephyr/mgmt/ec_host_cmd/ec_host_cmd.h>
#include <zephyr/mgmt/ec_host_cmd/backend.h> #include <zephyr/mgmt/ec_host_cmd/backend.h>
@ -32,12 +33,18 @@ BUILD_ASSERT(NUMBER_OF_CHOSEN_BACKENDS < 2, "Number of chosen backends > 1");
#define RX_HEADER_SIZE (sizeof(struct ec_host_cmd_request_header)) #define RX_HEADER_SIZE (sizeof(struct ec_host_cmd_request_header))
#define TX_HEADER_SIZE (sizeof(struct ec_host_cmd_response_header)) #define TX_HEADER_SIZE (sizeof(struct ec_host_cmd_response_header))
#ifdef CONFIG_EC_HOST_CMD_NOCACHE_BUFFERS
#define BUFFERS_CACHE_ATTR __nocache
#else
#define BUFFERS_CACHE_ATTR
#endif
COND_CODE_1(CONFIG_EC_HOST_CMD_HANDLER_RX_BUFFER_DEF, COND_CODE_1(CONFIG_EC_HOST_CMD_HANDLER_RX_BUFFER_DEF,
(static uint8_t hc_rx_buffer[CONFIG_EC_HOST_CMD_HANDLER_RX_BUFFER_SIZE] __aligned(4);), (static uint8_t hc_rx_buffer[CONFIG_EC_HOST_CMD_HANDLER_RX_BUFFER_SIZE] __aligned(4)
()) BUFFERS_CACHE_ATTR;), ())
COND_CODE_1(CONFIG_EC_HOST_CMD_HANDLER_TX_BUFFER_DEF, COND_CODE_1(CONFIG_EC_HOST_CMD_HANDLER_TX_BUFFER_DEF,
(static uint8_t hc_tx_buffer[CONFIG_EC_HOST_CMD_HANDLER_TX_BUFFER_SIZE] __aligned(4);), (static uint8_t hc_tx_buffer[CONFIG_EC_HOST_CMD_HANDLER_TX_BUFFER_SIZE] __aligned(4)
()) BUFFERS_CACHE_ATTR;), ())
#ifdef CONFIG_EC_HOST_CMD_DEDICATED_THREAD #ifdef CONFIG_EC_HOST_CMD_DEDICATED_THREAD
static K_KERNEL_STACK_DEFINE(hc_stack, CONFIG_EC_HOST_CMD_HANDLER_STACK_SIZE); static K_KERNEL_STACK_DEFINE(hc_stack, CONFIG_EC_HOST_CMD_HANDLER_STACK_SIZE);