michaelh/zephyr
1
0
Fork 0
Code Releases Activity

ethernet: dwmac: fix promiscuous mode

Browse source 
The dedicated PR (Promiscuous Mode) bit should be used instead of
the RA (Receive All) bit.

Signed-off-by: Nicolas Pitre <npitre@baylibre.com>
This commit is contained in:
Nicolas Pitre 2021-11-22 10:52:38 -05:00 • committed by Anas Nashif
commit e915dcad13
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
drivers/ethernet/eth_dwmac.c
View file

@ -487,13 +487,13 @@ static int dwmac_set_config(const struct device *dev,
case ETHERNET_CONFIG_TYPE_PROMISC_MODE: case ETHERNET_CONFIG_TYPE_PROMISC_MODE:
reg_val = REG_READ(MAC_PKT_FILTER); reg_val = REG_READ(MAC_PKT_FILTER);
if (config->promisc_mode && if (config->promisc_mode &&
!(reg_val & MAC_PKT_FILTER_RA)) { !(reg_val & MAC_PKT_FILTER_PR)) {
REG_WRITE(MAC_PKT_FILTER, REG_WRITE(MAC_PKT_FILTER,
reg_val | MAC_PKT_FILTER_RA); reg_val | MAC_PKT_FILTER_PR);
} else if (!config->promisc_mode && } else if (!config->promisc_mode &&
(reg_val & MAC_PKT_FILTER_RA)) { (reg_val & MAC_PKT_FILTER_PR)) {
REG_WRITE(MAC_PKT_FILTER, REG_WRITE(MAC_PKT_FILTER,
reg_val & ~MAC_PKT_FILTER_RA); reg_val & ~MAC_PKT_FILTER_PR);
} else { } else {
ret = -EALREADY; ret = -EALREADY;
} }