From e8e590eb46c2ee2e56a56e06234ee3c5bf49f1ab Mon Sep 17 00:00:00 2001 From: Ryan McClelland Date: Thu, 27 Mar 2025 16:54:56 -0700 Subject: [PATCH] drivers: i3c: fix read flag for i3c_hdr_ddr_read i3c_hdr_ddr_read is missing the I3C_MSG_READ. Add it. Signed-off-by: Ryan McClelland --- include/zephyr/drivers/i3c/hdr_ddr.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/zephyr/drivers/i3c/hdr_ddr.h b/include/zephyr/drivers/i3c/hdr_ddr.h index 6aaff610532..bd74538dd01 100644 --- a/include/zephyr/drivers/i3c/hdr_ddr.h +++ b/include/zephyr/drivers/i3c/hdr_ddr.h @@ -73,7 +73,7 @@ static inline int i3c_hdr_ddr_read(struct i3c_device_desc *target, uint8_t cmd, msg.buf = buf; msg.len = num_bytes; - msg.flags = I3C_MSG_STOP | I3C_MSG_HDR; + msg.flags = I3C_MSG_READ | I3C_MSG_STOP | I3C_MSG_HDR; msg.hdr_mode = I3C_MSG_HDR_DDR; msg.hdr_cmd_code = cmd; @@ -90,10 +90,10 @@ static inline int i3c_hdr_ddr_read(struct i3c_device_desc *target, uint8_t cmd, * @param target I3C target device descriptor. * @param write_buf Pointer to the data to be written * @param num_write Number of bytes to write - * @param write_cmd 7-bit command code for write + * @param read_cmd 7-bit command code for read * @param read_buf Pointer to storage for read data * @param num_read Number of bytes to read - * @param read_cmd 7-bit command code for read + * @param write_cmd 7-bit command code for write * * @retval 0 if successful * @retval -EBUSY Bus is busy.