diff --git a/.ruff-excludes.toml b/.ruff-excludes.toml index e1d1b2c53b9..ced46706deb 100644 --- a/.ruff-excludes.toml +++ b/.ruff-excludes.toml @@ -795,7 +795,6 @@ "SIM105", # https://docs.astral.sh/ruff/rules/suppressible-exception "SIM114", # https://docs.astral.sh/ruff/rules/if-with-same-arms "SIM115", # https://docs.astral.sh/ruff/rules/open-file-with-context-handler - "SIM201", # https://docs.astral.sh/ruff/rules/negate-equal-op "UP007", # https://docs.astral.sh/ruff/rules/non-pep604-annotation "UP015", # https://docs.astral.sh/ruff/rules/redundant-open-modes "UP030", # https://docs.astral.sh/ruff/rules/format-literals @@ -822,9 +821,6 @@ "UP031", # https://docs.astral.sh/ruff/rules/printf-string-formatting "UP032", # https://docs.astral.sh/ruff/rules/f-string ] -"./scripts/pylib/twister/twisterlib/jobserver.py" = [ - "SIM201", # https://docs.astral.sh/ruff/rules/negate-equal-op -] "./scripts/pylib/twister/twisterlib/mixins.py" = [ "UP004", # https://docs.astral.sh/ruff/rules/useless-object-inheritance ] @@ -856,7 +852,6 @@ "F541", # https://docs.astral.sh/ruff/rules/f-string-missing-placeholders "SIM102", # https://docs.astral.sh/ruff/rules/collapsible-if "SIM115", # https://docs.astral.sh/ruff/rules/open-file-with-context-handler - "SIM201", # https://docs.astral.sh/ruff/rules/negate-equal-op "UP004", # https://docs.astral.sh/ruff/rules/useless-object-inheritance "UP006", # https://docs.astral.sh/ruff/rules/non-pep585-annotation "UP015", # https://docs.astral.sh/ruff/rules/redundant-open-modes @@ -890,7 +885,6 @@ "F541", # https://docs.astral.sh/ruff/rules/f-string-missing-placeholders "SIM102", # https://docs.astral.sh/ruff/rules/collapsible-if "SIM110", # https://docs.astral.sh/ruff/rules/reimplemented-builtin - "SIM202", # https://docs.astral.sh/ruff/rules/negate-not-equal-op "UP015", # https://docs.astral.sh/ruff/rules/redundant-open-modes "UP031", # https://docs.astral.sh/ruff/rules/printf-string-formatting "UP032", # https://docs.astral.sh/ruff/rules/f-string diff --git a/scripts/pylib/twister/twisterlib/handlers.py b/scripts/pylib/twister/twisterlib/handlers.py index 72e2eaf0067..5322e1d1ecf 100755 --- a/scripts/pylib/twister/twisterlib/handlers.py +++ b/scripts/pylib/twister/twisterlib/handlers.py @@ -116,7 +116,7 @@ class Handler: logger.debug(f"Expected suite names:{expected_suite_names}") logger.debug(f"Detected suite names:{detected_suite_names}") if not expected_suite_names or \ - not harness_status == TwisterStatus.PASS: + harness_status != TwisterStatus.PASS: return if not detected_suite_names: self._missing_suite_name(expected_suite_names, handler_time) diff --git a/scripts/pylib/twister/twisterlib/jobserver.py b/scripts/pylib/twister/twisterlib/jobserver.py index 731f9fc3556..d004a451c14 100644 --- a/scripts/pylib/twister/twisterlib/jobserver.py +++ b/scripts/pylib/twister/twisterlib/jobserver.py @@ -150,14 +150,14 @@ class GNUMakeJobClient(JobClient): # Use F_GETFL to see if file descriptors are valid if pipe: rc = fcntl.fcntl(pipe[0], fcntl.F_GETFL) - if not rc & os.O_ACCMODE == os.O_RDONLY: + if rc & os.O_ACCMODE != os.O_RDONLY: logger.warning( "FD %s is not readable (flags=%x); " "ignoring GNU make jobserver", pipe[0], rc) pipe = None if pipe: rc = fcntl.fcntl(pipe[1], fcntl.F_GETFL) - if not rc & os.O_ACCMODE == os.O_WRONLY: + if rc & os.O_ACCMODE != os.O_WRONLY: logger.warning( "FD %s is not writable (flags=%x); " "ignoring GNU make jobserver", pipe[1], rc) diff --git a/scripts/pylib/twister/twisterlib/runner.py b/scripts/pylib/twister/twisterlib/runner.py index e7ad7987d77..04200fef362 100644 --- a/scripts/pylib/twister/twisterlib/runner.py +++ b/scripts/pylib/twister/twisterlib/runner.py @@ -1730,7 +1730,7 @@ class TwisterRunner: the static filter stats. So need to prepare them before pipline starts. ''' for instance in self.instances.values(): - if instance.status == TwisterStatus.FILTER and not instance.reason == 'runtime filter': + if instance.status == TwisterStatus.FILTER and instance.reason != 'runtime filter': self.results.filtered_static_increment() self.results.filtered_configs_increment() self.results.filtered_cases_increment(len(instance.testsuite.testcases))