michaelh/zephyr
1
0
Fork 0
Code Releases Activity

drivers/sensor: lis2mdl: Fix temperature sample handling

Browse source 
The lis2mdl temperature samples work with a level of 25 Celsius.
When temperature goes below that level the samples become negative
and there was an issue in properly propagating the sign.

Fix #35910

Signed-off-by: Armando Visconti <armando.visconti@st.com>
This commit is contained in:
Armando Visconti 2021-06-03 14:51:56 +02:00 • committed by Kumar Gala
commit e879be1dbb
2 changed files with 5 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
drivers/sensor/lis2mdl/lis2mdl.c
View file

@ -117,8 +117,9 @@ static void lis2mdl_channel_get_temp(const struct device *dev,
{
struct lis2mdl_data *drv_data = dev->data;
val->val1 = drv_data->temp_sample / 100;
val->val2 = (drv_data->temp_sample % 100) * 10000;
/* formula is temp = 25 + (temp / 8) C */
val->val1 = 25 + drv_data->temp_sample / 8;
val->val2 = (drv_data->temp_sample % 8) * 1000000 / 8;
}
static int lis2mdl_channel_get(const struct device *dev,
@ -266,7 +267,6 @@ static int lis2mdl_sample_fetch_temp(const struct device *dev)
{
struct lis2mdl_data *lis2mdl = dev->data;
int16_t raw_temp;
int32_t temp;
/* fetch raw temperature sample */
if (lis2mdl_temperature_raw_get(lis2mdl->ctx, &raw_temp) < 0) {
@ -274,9 +274,7 @@ static int lis2mdl_sample_fetch_temp(const struct device *dev)
return -EIO;
}
/* formula is temp = 25 + (temp / 8) C */
temp = (sys_le16_to_cpu(raw_temp) & 0x8FFF);
lis2mdl->temp_sample = 2500 + (temp * 100) / 8;
lis2mdl->temp_sample = (sys_le16_to_cpu(raw_temp));
return 0;
}

2
drivers/sensor/lis2mdl/lis2mdl.h
View file

@ -56,7 +56,7 @@ struct lis2mdl_data {
const struct device *bus;
uint16_t i2c_addr;
int16_t mag[3];
int32_t temp_sample;
int16_t temp_sample;
stmdev_ctx_t *ctx;